Xen project Mailing List

Varargs in AdapterVifCallbacks.

To: "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>

From: Martin Harvey <martin.harvey@xxxxxxxxxx>

Date: Thu, 12 May 2022 14:25:33 +0000

Accept-language: en-US

Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none

Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tRb46uXAnWanVrz46Gxk1g35ur1vZB24ko9mPyFnOcI=; b=kROEmgLZdlOAIzhxf2NXZhUEMScVpkOWBsBv2yLYzErNggU8DKe4e+/bDqcmSgJy5UUSDxSn96JaWE+dbiZzSw0TV8u4SZ2pwQnTxEhVEKeseyFhVIuQMDOHko9FbyEPZNgnZ6ej+7T/8XfJf/YEeN9lBVqNTa9lJLOj8sgyM7Izg53/zx3NHZyBuA5BXmdm8xrwObduEKNeXU9wCg8+lx9dXgGR2FpmRvWWT3zXHdcWEaDphTQcmHH4IQh0mFYc/SE8JDdmjdlCh+bt0d+rZl/sqWajmmbHJk22B7MJzwXGW+43YqFZkl9eTg1GYcVPnHfPr3XGfLw7UfobpOD8Kg==

Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oGBdhWN3N4RLOu5xm3xUcxAXyNISQp2kWv9dz+Zoca/FtxtI2A1qiUswZac+NtzBkNRC+GGMhuM8o01N7Lsuj3WRsXRHvV9uXQqeVk7RFCHGqsBOsbPmdL8vrqvK0902KjTe4EJOWULh4vAT0qkbn+yL9zNd+EDRqBE41HA9Pk2Otl26WY8+kWdaOHMzJFL62Sr7m9cbN8gnANR/PZqwLNguYn48s/u2EVaSpKMGLEkFmH71IaZOUV38YjFB8KgLcklt48qPD/YNhQ5l4WRcf5oc8gENI0L2hYBekfcuOMhX4ZuHXpRrCojDnRXMSG779+1OezTuq1fwgUrp8D1Smw==

Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;

Delivery-date: Thu, 12 May 2022 14:25:44 +0000

Ironport-data: A9a23:KC/iMaxMbGzeqd+HOHp6t+drxyrEfRIJ4+MujC+fZmUNrF6WrkUPy GMbX2HVO/6OYzGme9glOtiypEgG6J6Bn9QxT1FvrSAxQypGp/SeCIXCJC8cHc8zwu4v7q5Dx 59DAjUVBJlsFhcwnj/0bv656yMUOZigHtIQMsadUsxKbVIiGX5JZS5LwbZj2NY12ILhWWthh PupyyHhEA79s9JLGjp8B5Kr8HuDa9yr5Vv0FnRnDRx6lAe2e0s9VfrzFonoR5fMeaFGH/bSe gr25OrRElU1XfsaIojNfr7TKiXmS1NJVOSEoiI+t6OK2nCuqsGuu0qS2TV1hUp/0l20c95NJ NplkbuubCo0LpPwtvkZChBmPjteGat5weqSSZS/mZT7I0zuVVLJm6krKX5seIoS96BwHH1E8 uEeJHYVdBefiumqwbW9DO5xmsAkK8qtN4Qa0p1i5WiBUbB6HtacGOOTuoIwMDQY36iiGd7bb tAFaDwpbB3afRBeElwWFIg/jKGjgXyXnzhw9wvM+/FnsjO7IApZ1JzLCuPrSt2wWdhQj0XH/ knd00f1DURPXDCY4X/fmp62vcfQnCW+QJxXGLCm+/pChFyI2ndVGBAQTUG8o/Sylgi5Qd03F qAP0i8nrKx38VPxSND4B028uCTd4UNaXMdMGeon7g3L0rDT/wuSGmkDSHhGdcAis8g1Azct0 zdlgu/UONCmi5XNIVr1y1tehWra1fQ9RYPaWRI5cA==

Ironport-hdrordr: A9a23:uDw47a6chD6ASqgJiQPXwUqBI+orL9Y04lQ7vn2ZFiY5TiXIra qTdaogviMc0AxhPk3I6urwQZVoIEmsvKKdhLN8AV7MZniDhILFFuBfBOjZsnXd8k/Fh4lgPM 5bGsAQZuEYZmIK7voSlTPIdurIt+P3kpxA692/815dCSVRL41w5QZwDQiWVmdsQhNdOJY/HJ 2AouJaujuJYx0sH46GL0hAe9KGi8zAlZrgbxJDLQUg8hOygTSh76O/OwSE3y0ZTyhEzd4ZgC X4ek3Cl+meWsOAu1HhPlzontVrcRzau5t+7fm3+4cow/PX+0WVjcpaKv+/VXsO0ZmSAR4R4a LxSlEbTo9OAjrqDxuIiAqo1A/63Dk07Xj+jVeenHv4uMT8ACk3EsxbmOtiA2/kAmcbzaNBOZ hwrhekXltsfG39tTW448KNWwBhl0Kyr3ZnmekPj2ZHWY9bbLNKt4QQ8E5cDZ9FRUvBmfYaOf grCNuZ6OddcFucYXyctm5zwMa0VnB2GhudWEANtsGczjATlnFkyEkTwtAZgx47heUAYogB4/ 6BPrVjlblIQMNTZaVhBP0ZSc/yEWDJSQKkChPgHb0mLtB2B5vgke+K3Fxu3pDWRHUh9upMpL 3RFFVFqGU1Z0XiTcWTwZwjyGG9fFmA

List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>

Thread-index: AdhmC7aA17C99R2kT1uNNjmZQqMw8Q==

Thread-topic: Varargs in AdapterVifCallbacks.

Some of the callback functions specified in the XENVIF_VIF interface rely on varargs callbacks. A little experimentation with the aforementioned makes me believe that varargs is not as wonderful as it should be in a kernel context. Additionally, it’s not used in windows kernel API’s anywhere else, presumably for a reason.

Any complaints if I remove varargs from upcoming v9 of XENVIF_VIF interface? Speak now or forever …

MH.