[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Varargs in AdapterVifCallbacks.


  • To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
  • From: "Durrant, Paul" <xadimgnik@xxxxxxxxx>
  • Date: Thu, 12 May 2022 15:38:32 +0100
  • Delivery-date: Thu, 12 May 2022 14:38:37 +0000
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>

On 12/05/2022 15:25, Martin Harvey wrote:
Some of the callback functions specified in the XENVIF_VIF interface rely on varargs callbacks. A little experimentation with the aforementioned makes me believe that varargs is not as wonderful as it should be in a kernel context. Additionally, it’s not used in windows kernel API’s anywhere else, presumably for a reason.

Not necessarily. Can you elaborate on "not as wonderful as it should be"?


Any complaints if I remove varargs from upcoming v9  of XENVIF_VIF interface? Speak now or forever …


I could be persuaded that an argument struct is a suitable replacement but I'd like to understand what the exact nature of the problem is.

  Paul





 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.