[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [PATCH 1/5] Fix Length calculation in PdoQueryId
Decrease Length by the string length of the current ID before moving the Buffer value to the end of the current ID. Without this, Length is not decreased, leading to potential issues with the next call to RtlStringCbPrintfW. Note: the second chunk it to maintain consistent ordering of operations for clarity, and has no functional change. Signed-off-by: Owen Smith <owen.smith@xxxxxxxxx> --- src/xenvkbd/pdo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/xenvkbd/pdo.c b/src/xenvkbd/pdo.c index 3591e14..256859f 100644 --- a/src/xenvkbd/pdo.c +++ b/src/xenvkbd/pdo.c @@ -1356,11 +1356,11 @@ PdoQueryId( Revision->Number); ASSERT(NT_SUCCESS(status)); - Buffer += wcslen(Buffer); Length -= (ULONG)(wcslen(Buffer) * sizeof (WCHAR)); + Buffer += wcslen(Buffer); - Buffer++; Length -= sizeof (WCHAR); + Buffer++; --Index; } -- 2.41.0.windows.3
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |