[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 2/5] Remove REV from DeviceID



Driver upgrades use HardwareIDs (or CompatibleIDs) to match the child INF 
DDInstall
section (stored as matching device id), but use the DeviceID to generate the 
device
instance path. By keeping the device instance path the same over upgrades, the 
network
stack should identify this as an upgrade, rather than 'replacement hardware', 
and
not generate a new network connection, which would require network settings to 
be
copied from the existing network connection to the new network connection.

Note: Adds a strict requirement on child INF DDInstall sections, to specify the 
full
hardware ID (including revision) to guarantee interface versions are correctly 
supported

Signed-off-by: Owen Smith <owen.smith@xxxxxxxxx>
---
 src/xenvkbd/pdo.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/src/xenvkbd/pdo.c b/src/xenvkbd/pdo.c
index 256859f..5b52aad 100644
--- a/src/xenvkbd/pdo.c
+++ b/src/xenvkbd/pdo.c
@@ -1318,18 +1318,12 @@ PdoQueryId(
         break;
 
     case BusQueryDeviceID: {
-        ULONG                   Index;
-        PXENVKBD_PDO_REVISION    Revision;
-
         Type = REG_SZ;
-        Index = ARRAYSIZE(PdoRevision) - 1;
-        Revision = &PdoRevision[Index];
 
         status = RtlStringCbPrintfW(Buffer,
                                     Id.MaximumLength,
-                                    L"XENVKBD\\VEN_%hs&DEV_HID&REV_%08X",
-                                    __PdoGetVendorName(Pdo),
-                                    Revision->Number);
+                                    L"XENVKBD\\VEN_%hs&DEV_HID",
+                                    __PdoGetVendorName(Pdo));
         ASSERT(NT_SUCCESS(status));
 
         Buffer += wcslen(Buffer);
-- 
2.41.0.windows.3




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.