Re: [PATCH 2/2] Xenbus remove event message information from INF file

["Tu Dinh" <ngoc-tu.dinh@xxxxxxxxxx>]

On 14/04/2026 10:01, Owen Smith wrote:
> From: david ambu <david.preetham@xxxxxxxxxx>
> 
> 1876359a4fcdc7ee794f13ee190c05df6299d7a7 made the event message
> information in the INF file redundant.
> 
> Signed-off-by: david ambu <david.preetham@xxxxxxxxxx>
> 
> Remove xenbus_monitor.dll from INF file
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>

I'd prefer that the DLL is removed from the build/packaging altogether 
due to the new rule on unreferenced files [1], but we can do that later.

Reviewed-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>

[1] 
https://techcommunity.microsoft.com/blog/hardware-dev-center/attention-hdc-is-changing-the-policy-on-signing-unreferenced-files-in-driver-pac/4495518

> ---
>   src/xenbus.inf | 11 +----------
>   1 file changed, 1 insertion(+), 10 deletions(-)
> 
> diff --git a/src/xenbus.inf b/src/xenbus.inf
> index adc70bd..5499791 100644
> --- a/src/xenbus.inf
> +++ b/src/xenbus.inf
> @@ -51,7 +51,6 @@ xen.sys=0,,
>   xenbus.sys=0,,
>   xenfilt.sys=0,,
>   xenbus_monitor.exe=0,,
> -xenbus_monitor.dll=0,,
>   
>   [XenBus_CopyFiles]
>   xen.sys
> @@ -60,7 +59,6 @@ xenfilt.sys
>   
>   [Monitor_CopyFiles]
>   
> xenbus_monitor_@MAJOR_VERSION@_@MINOR_VERSION@_@MICRO_VERSION@_@BUILD_NUMBER@.exe,xenbus_monitor.exe
> -xenbus_monitor_@MAJOR_VERSION@_@MINOR_VERSION@_@MICRO_VERSION@_@BUILD_NUMBER@.dll,xenbus_monitor.dll
>   
>   [Manufacturer]
>   %Vendor%=Inst,NT@INF_ARCH@
> @@ -80,7 +78,7 @@ FeatureScore=0xFE
>   AddReg = XenBus_Interrupts
>   
>   [XenBus_Inst.Services]
> -AddService=xenbus_monitor,%SPSVCSINST_STARTSERVICE%,Monitor_Service,Monitor_EventLog
> +AddService=xenbus_monitor,%SPSVCSINST_STARTSERVICE%,Monitor_Service
>   AddService=xenbus,%SPSVCINST_ASSOCSERVICE%,XenBus_Service
>   AddService=xenfilt,,XenFilt_Service,
>   
> @@ -148,13 +146,6 @@ HKR,"Parameters","DialogTitle",0x00000000,%DialogTitle%
>   HKR,"Parameters","DialogText",0x00000000,%DialogText%
>   HKR,"Parameters","DialogQuestion",0x00000000,%DialogQuestion%
>   
> -[Monitor_EventLog]
> -AddReg=Monitor_EventLog_AddReg
> -
> -[Monitor_EventLog_AddReg]
> -HKR,,EventMessageFile,0x00020000,"%%SystemRoot%%\System32\xenbus_monitor_@MAJOR_VERSION@_@MINOR_VERSION@_@MICRO_VERSION@_@BUILD_NUMBER@.dll"
> -HKR,,TypesSupported,0x00010001,7
> -
>   [Strings]
>   
>   Vendor="@VENDOR_NAME@"



--
Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech