[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/2] Xenbus remove event message information from INF file


  • To: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Owen Smith <owen.smith@xxxxxxxxxx>
  • Date: Tue, 14 Apr 2026 08:45:01 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pQxiDS+DMUSRoBjk+Jflgi3ajUp02MAJ3m0K/V6PfOc=; b=ExghTYXE8ur6ptbm7N3x5jYGdkqdfTVs+qmhcsjTmSNf3Us7HpK5M4BPQYOsU0gRphbgVR9uXBKObhqn+85/TfzarTAhpl72LaRv5CGQFT6KXodP+PpwO4peowaR9N8MA54w8HHvfnWPDhqvZCx1d6NFN8SgD7p8ob1A3dRM6bTySzLxTzeACnxzMqlHLtvnc+apVUBRP24I4pIN6C6urU1y04E7gYsNjotqw1fVK5zXCtNW62mQU1RXp7jw00fO95Y02DEyQwexNF9SZUDAQXCN0AorfLYY4vwy+GVpk8wtzUZGRbzd1mKDDTekH8wlQ01s7N6zvp9ryV7haA5ZZQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Xwt/O3G8Op1tV8yIlQi/0zKortiiuY3pmWvB1Jg7Bl8GN2YGIV5qmRt6BlINSdQI4V/1tK5h3eTN14vhH4S32jzxE3wJGz4elz0lcdogwdZRF2RfjNnaulOR79k/4ek2yW+SddxULogPnaEHje6Pxf18PMWDNsbKD7Im9xeVAK8BFVHrq6MG1eMKZ/No0NEJofYovZreRmKItDMN6qKpirR9qB7U33eq2AySAZWv8sGPxMUA5PNDbyd7MxT2vX6DrpgAxF4eq2IDjv56+gQUQ8LwFONiKCSIqpvXSlTSbOSDurAR6vW+wEWd9bKYgbqKqRAP/qegoL2A0dDcY7MZvA==
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
  • Cc: David ambu <david.preetham@xxxxxxxxxx>
  • Delivery-date: Tue, 14 Apr 2026 08:45:12 +0000
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
  • Msip_labels:
  • Thread-index: AQHcraNq6DTMUCVhg0qClt7cF3ws7rXebkeAgAAKkwCAAAFuBg==
  • Thread-topic: [PATCH 2/2] Xenbus remove event message information from INF file

The new rule on unreferenced files is on my to-do list, as it means reorganizing
the build output to some degree. Only INF referenced files in the 'driver' 
output, and
symbols, etc in another location.

Owen

________________________________________
From: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>
Sent: 14 April 2026 9:38 AM
To: Owen Smith; win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Cc: David ambu
Subject: Re: [PATCH 2/2] Xenbus remove event message information from INF file

On 14/04/2026 10:01, Owen Smith wrote:
> From: david ambu <david.preetham@xxxxxxxxxx>
>
> 1876359a4fcdc7ee794f13ee190c05df6299d7a7 made the event message
> information in the INF file redundant.
>
> Signed-off-by: david ambu <david.preetham@xxxxxxxxxx>
>
> Remove xenbus_monitor.dll from INF file
>
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>

I'd prefer that the DLL is removed from the build/packaging altogether
due to the new rule on unreferenced files [1], but we can do that later.

Reviewed-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>

[1]
https://techcommunity.microsoft.com/blog/hardware-dev-center/attention-hdc-is-changing-the-policy-on-signing-unreferenced-files-in-driver-pac/4495518

> ---
>   src/xenbus.inf | 11 +----------
>   1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/src/xenbus.inf b/src/xenbus.inf
> index adc70bd..5499791 100644
> --- a/src/xenbus.inf
> +++ b/src/xenbus.inf
> @@ -51,7 +51,6 @@ xen.sys=0,,
>   xenbus.sys=0,,
>   xenfilt.sys=0,,
>   xenbus_monitor.exe=0,,
> -xenbus_monitor.dll=0,,
>
>   [XenBus_CopyFiles]
>   xen.sys
> @@ -60,7 +59,6 @@ xenfilt.sys
>
>   [Monitor_CopyFiles]
>   
> xenbus_monitor_@MAJOR_VERSION@_@MINOR_VERSION@_@MICRO_VERSION@_@BUILD_NUMBER@.exe,xenbus_monitor.exe
> -xenbus_monitor_@MAJOR_VERSION@_@MINOR_VERSION@_@MICRO_VERSION@_@BUILD_NUMBER@.dll,xenbus_monitor.dll
>
>   [Manufacturer]
>   %Vendor%=Inst,NT@INF_ARCH@
> @@ -80,7 +78,7 @@ FeatureScore=0xFE
>   AddReg = XenBus_Interrupts
>
>   [XenBus_Inst.Services]
> -AddService=xenbus_monitor,%SPSVCSINST_STARTSERVICE%,Monitor_Service,Monitor_EventLog
> +AddService=xenbus_monitor,%SPSVCSINST_STARTSERVICE%,Monitor_Service
>   AddService=xenbus,%SPSVCINST_ASSOCSERVICE%,XenBus_Service
>   AddService=xenfilt,,XenFilt_Service,
>
> @@ -148,13 +146,6 @@ HKR,"Parameters","DialogTitle",0x00000000,%DialogTitle%
>   HKR,"Parameters","DialogText",0x00000000,%DialogText%
>   HKR,"Parameters","DialogQuestion",0x00000000,%DialogQuestion%
>
> -[Monitor_EventLog]
> -AddReg=Monitor_EventLog_AddReg
> -
> -[Monitor_EventLog_AddReg]
> -HKR,,EventMessageFile,0x00020000,"%%SystemRoot%%\System32\xenbus_monitor_@MAJOR_VERSION@_@MINOR_VERSION@_@MICRO_VERSION@_@BUILD_NUMBER@.dll"
> -HKR,,TypesSupported,0x00010001,7
> -
>   [Strings]
>
>   Vendor="@VENDOR_NAME@"



--
Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.