Re: [PATCH 00/17] Update SAL annotations in xeniface

[Owen Smith <owen.smith@xxxxxxxxxx>]

The entire patch series looks good
Reviewed-by: Owen Smith <owen.smith@xxxxxxxxxx>

________________________________________
From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> on behalf of 
Mounah Honore Cesaire <cesaire.mounah@xxxxxxxxxx>
Sent: 05 October 2026 4:57 PM
To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH 00/17] Update SAL annotations in xeniface


On 10/5/26 4:27 PM, Owen Smith wrote:
> Hi,
>
> This series seems to be missing patches 10 through 17
>
> Owen


Indeed, Sorry. I will send the rest.

Césaire


>
> ________________________________________
> From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> on behalf of 
> Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
> Sent: 05 October 2026 1:04 PM
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Césaire Mounah
> Subject: [PATCH 00/17] Update SAL annotations in xeniface
>
> This update concerns updating and fixing SAL annotations in the xeniface 
> driver.
>
> Césaire Mounah (17):
>    xeniface: Sync common files with xenbus
>    Convert to SAL 2.0 annotations
>    util: fix some annotations
>    wmi: fix some anntotations
>    ioctl: fix annotations
>    fdo: fix annotations
>    update string typedefs in all include files
>    wmi: fix annotation of AccessWmiBuffer
>    fix XENBUS_GNTTAB_QUERY_REFERENCE annotation
>    driver: fix annotation errors
>    xc: fix annotations
>    fdo: suppress warning in FdoQueryInterface
>    ioctl: fix annotation of __CaptureUserBuffer
>    wmi: fix output buffer annotations
>    include: update the annotations of shared interfaces
>    xeniface: route AccessWmiBuffer unknown-type exit through common path
>    util: fix annotation of __wcstok_r
>
>   include/cache_interface.h       |  76 ++--
>   include/evtchn_interface.h      |  72 ++--
>   include/gnttab_interface.h      |  88 ++---
>   include/shared_info_interface.h |  44 +--
>   include/store_interface.h       |  84 ++---
>   include/suspend_interface.h     |  24 +-
>   include/xencontrol.h            | 165 +++++----
>   src/xencontrol/xencontrol.c     | 337 ++++++++---------
>   src/xeniface/assert.h           |  82 ++--
>   src/xeniface/driver.c           |  32 +-
>   src/xeniface/fdo.c              | 348 ++++++++---------
>   src/xeniface/fdo.h              |  26 +-
>   src/xeniface/ioctl_evtchn.c     | 144 +++----
>   src/xeniface/ioctl_gnttab.c     | 132 +++----
>   src/xeniface/ioctl_sharedinfo.c |  10 +-
>   src/xeniface/ioctl_store.c      | 162 ++++----
>   src/xeniface/ioctl_suspend.c    |  66 ++--
>   src/xeniface/ioctls.c           |  50 +--
>   src/xeniface/ioctls.h           | 272 +++++++-------
>   src/xeniface/irp_queue.c        |  46 +--
>   src/xeniface/irp_queue.h        |  28 +-
>   src/xeniface/log.h              |  16 +-
>   src/xeniface/mutex.h            |  10 +-
>   src/xeniface/names.h            |  18 +-
>   src/xeniface/registry.c         | 452 ++++++++++++----------
>   src/xeniface/registry.h         | 207 ++++++-----
>   src/xeniface/thread.c           |  38 +-
>   src/xeniface/thread.h           |  18 +-
>   src/xeniface/util.h             |  90 +++--
>   src/xeniface/wmi.c              | 638 ++++++++++++++++----------------
>   src/xeniface/wmi.h              |  18 +-
>   31 files changed, 1954 insertions(+), 1839 deletions(-)
>
> --
> 2.55.0.windows.5
>
>
>
> --
> Césaire Mounah | Vates Windows Guest Tools Engineer
>
> XCP-ng & Xen Orchestra - Vates solutions
>
> web: https://vates.tech


--
Césaire Mounah | Vates Windows Guest Tools Engineer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech