Re: [PATCH 0/6] xennet: update annotations to SAL 2.0

[Owen Smith <owen.smith@xxxxxxxxxx>]

The full patch series
Reviewed-by: Owen Smith <owen.smith@xxxxxxxxxx>

________________________________________
From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> on behalf of 
Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
Sent: 05 October 2026 4:54 PM
To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Cc: Césaire Mounah
Subject: [PATCH 0/6] xennet: update annotations to SAL 2.0

Update SAL annotations in xennet to SAL 2.0.
This update has 3 main changes:

1. Synchronize common files with xeniface.
* xennet: sync common files with xeniface

2. Convert and fix old annotations to SAL 2.0.
* xennet: convert and fix old annotations to SAL 2.0: Mechanical pass
* xennet: fix IN annotations
* xennet: use correct string annotations

3. Suppress warnings raised by static analysis.
* adapter: fix Unitialized *Interface in _QueryInterface
* receiver: suppress warning on *Pause being unitialized in
    _ReceiverPushPackets

Césaire Mounah (6):
  xennet: sync common files with xeniface
  xennet: convert old annotations to SAL 2.0: Mechanical pass
  xennet: fix IN annotations
  xennet: use correct string annotations
  adapter: fix Unitialized *Interface in _QueryInterface
  receiver: suppress warning on *Pause being unitialized in
    _ReceiverPushPackets

 include/store_interface.h   |  84 ++++-----
 include/suspend_interface.h |  24 +--
 include/vif_interface.h     | 158 ++++++++---------
 src/xennet/adapter.c        | 333 ++++++++++++++++++------------------
 src/xennet/adapter.h        |  32 ++--
 src/xennet/assert.h         |  83 ++++-----
 src/xennet/dbg_print.h      |  20 +--
 src/xennet/driver.c         |  20 +--
 src/xennet/driver.h         |   2 +-
 src/xennet/miniport.c       |  66 +++----
 src/xennet/miniport.h       |   6 +-
 src/xennet/receiver.c       | 111 ++++++------
 src/xennet/receiver.h       |  44 ++---
 src/xennet/string.c         |  28 +--
 src/xennet/string.h         |  10 +-
 src/xennet/transmitter.c    |  60 +++----
 src/xennet/transmitter.h    |  22 +--
 src/xennet/util.h           | 102 ++++++-----
 18 files changed, 611 insertions(+), 594 deletions(-)

--
2.55.0.windows.5



--
Césaire Mounah | Vates Windows Guest Tools Engineer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech