Re: [PATCH] xennet: Restore FALSE return value in _IsZeroMemory

[Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>]

On 08/10/2026 11:40, Césaire Mounah wrote:
> Last patch set ("Update annotations to SAL 2.0") accidentally changed
> the return value in _IsZeroMemory during the conversion.
> Restore the original FALSE return.
> 
> Signed-off-by: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
> ---
>   src/xennet/assert.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/xennet/assert.h b/src/xennet/assert.h
> index ef5abe2..ac25718 100644
> --- a/src/xennet/assert.h
> +++ b/src/xennet/assert.h
> @@ -166,7 +166,7 @@ _IsZeroMemory(
>       while (Offset < Length) {
>           if (*((PUCHAR)Buffer + Offset) != 0) {
>               Error("%s: non-zero byte in %s (0x%p+0x%x)\n", Caller, Name, 
> Buffer, Offset);
> -            return TRUE;
> +            return FALSE;
>           }
>           Offset++;
>       }

Reviewed-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>


--
Ngoc Tu Dinh | Vates XCP-ng Developer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech