[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xennet: Restore FALSE return value in _IsZeroMemory
- To: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>, Césaire Mounah <cesaire.mounah@xxxxxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Owen Smith <owen.smith@xxxxxxxxxx>
- Date: Thu, 8 Oct 2026 10:21:14 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pIb85QebIujNVvxQtSe74DfAgFGaeAjdTQcYIDFuzeA=; b=Nt3g+7HdJkBCMx+72TPZd2rXDX/RfRW0FsBCuHz7Em2oJf5nRh30FyuD+xIuojtlyoYbNCVQV16bE++TUwT/bQgKiXZ2ZVzfgjxOnaoTjk0cl4JTBcofoq8UgzmsKP+nOZcd1y3XYycrHWXL+lLh4HJ6M5Gs9tAtwqt/+2skqPF03gyFklYlJCGLz93gWPDFV6jjrOnGuRjuEPErUrEFqnkpuKjZhVXxA0TvMc7fRWYTRTgA0Wq+FymtHB3LpbkN+qpAiZfvbTYCbux5DHy9ZZsTVkudACPu2oLw/zVPqhXevfS4EwZUI2zbdIXrDB/bdofaOUx9ClmJttAdCQB/qQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qtcOpontBvB12BN62Dd9K2BR5++x0/UAa+tSfCS2Z7NPK/IP2E2qd6oUOGjiJAPYwDHD9y4KPZbKmEJ9KL/3GSPlcwU7tfq9Aj9okGzCY+NltKI7tzHACILDL0JsXaPuUNACGWcw3T0UQndiM0Ps3mLVP+8MsTd5nzwkHksJoZcIMFrOEZEc3BkIjJ5499yEkal5G28uYqVUIzKWNA2Al0mTRoxrhzZNGuWuQPalHCN+uqEvytUEzWyTnebAxYuGSCSLW9A7DBBg0i3qzuCI/aTXyTuze+/DimHAaFgwK2zTqRUkZ7Ife+XbkGghpj7Crf+eJxaDmTgN5p7QNNoJlw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Delivery-date: Thu, 08 Oct 2026 10:21:21 +0000
- List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
- Msip_labels:
- Thread-index: AQHdVwkEh/UmhvWXrkehy0EN1fDX1rbzZCcAgAALO9g=
- Thread-topic: [PATCH] xennet: Restore FALSE return value in _IsZeroMemory
Reviewed and applied, thanks
Owen
________________________________________
From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> on behalf of Tu
Dinh <ngoc-tu.dinh@xxxxxxxxxx>
Sent: 08 October 2026 10:40 AM
To: Césaire Mounah; win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH] xennet: Restore FALSE return value in _IsZeroMemory
On 08/10/2026 11:40, Césaire Mounah wrote:
> Last patch set ("Update annotations to SAL 2.0") accidentally changed
> the return value in _IsZeroMemory during the conversion.
> Restore the original FALSE return.
>
> Signed-off-by: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
> ---
> src/xennet/assert.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/xennet/assert.h b/src/xennet/assert.h
> index ef5abe2..ac25718 100644
> --- a/src/xennet/assert.h
> +++ b/src/xennet/assert.h
> @@ -166,7 +166,7 @@ _IsZeroMemory(
> while (Offset < Length) {
> if (*((PUCHAR)Buffer + Offset) != 0) {
> Error("%s: non-zero byte in %s (0x%p+0x%x)\n", Caller, Name,
> Buffer, Offset);
> - return TRUE;
> + return FALSE;
> }
> Offset++;
> }
Reviewed-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>
--
Ngoc Tu Dinh | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
|
