[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xeniface: Restore FALSE return value in _IsZeroMemory
- To: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>, Césaire Mounah <cesaire.mounah@xxxxxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Owen Smith <owen.smith@xxxxxxxxxx>
- Date: Thu, 8 Oct 2026 10:18:20 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0QLpJ/lzikb/PLTfI8RvBGU92j5c0ZhqLlvIXAVuUFM=; b=bGcZf2nMMEQVU3FvvEOoktO7CQeLtkvrPV59OpaAoHQIeNj9uytlJFJpN80OhHNoNFebbWojqoa9yGxrEfrY3mDba+5O9rXMiPKQ8Yrd7g7AhJHGrV3mJ82p+sgHkTX2XVEp3UkuETBTNpibpF1lULl2CcC6vcFWjX/fMJh79fWto/VFyOV0t3Xjqp0hLyzMH9TwWNEp5luOOovP3ke8v2OS/6uNvxaXuPE3ilHSkIGvu16dL2pViBa8fVDeZF9lGmnLsooF6QpWPV2tBHPUwAYGo4B7/kN6lFzyxnmjao7Hi3IZUPP3240XBw9dPMlZkVdnyXWp5iBVpQvgzIYRWw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JhL8Vo24UHJOMlFae3bl0ibz1aEE1j4YtrGJFk1TVhRMJKENs+qeVWGas8Mg6wmUhdu3kKQhK6J42fucV6LvhCWDu9jYoJ5udK284Tl0uo8ey2ZRxOiGO6mE0Rm7cC4jCuKFIfwvSmLm/O3snFRyyO3qZkFW4TRk6387Brm0wTeTmF7F2E0aP7MklSnMdUw/dh48FN2fLpJmaHg0AGM/sz7XPA8NHK6RKPJWJUWCWJby4RjITV4ooZxYTxJe9tFtypxQbxUHyGP5ePCZvHC9fA8SlWsBzmBYTa9rAjgHe4QXlTJ6xybd1QrCVMauxAiLrce5o1Sf6kf4KTc7jlRYTA==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Delivery-date: Thu, 08 Oct 2026 10:18:27 +0000
- List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
- Msip_labels:
- Thread-index: AQHdVwiJMGQ3X1X6Rk6vO8KhZpFb07bzZCEAgAAKZDU=
- Thread-topic: [PATCH] xeniface: Restore FALSE return value in _IsZeroMemory
Reviewed and applied, thanks
Owen
________________________________________
From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> on behalf of Tu
Dinh <ngoc-tu.dinh@xxxxxxxxxx>
Sent: 08 October 2026 10:40 AM
To: Césaire Mounah; win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH] xeniface: Restore FALSE return value in _IsZeroMemory
On 08/10/2026 11:37, Césaire Mounah wrote:
> Commit 54d43f78 ("Sync files with xenbus") accidentally changed
> the return value in _IsZeroMemory during the conversion.
> Restore the original FALSE return.
>
> Signed-off-by: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
> ---
> src/xeniface/assert.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/xeniface/assert.h b/src/xeniface/assert.h
> index 64d72cd..dfac6e1 100644
> --- a/src/xeniface/assert.h
> +++ b/src/xeniface/assert.h
> @@ -166,7 +166,7 @@ _IsZeroMemory(
> while (Offset < Length) {
> if (*((PUCHAR)Buffer + Offset) != 0) {
> Error("%s: non-zero byte in %s (0x%p+0x%x)\n", Caller, Name,
> Buffer, Offset);
> - return TRUE;
> + return FALSE;
> }
> Offset++;
> }
Reviewed-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>
--
Ngoc Tu Dinh | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
|
