[PATCH 13/21] xenvif: fix inconsistent annotation between declarations and definitions

[Césaire Mounah <cesaire.mounah@xxxxxxxxxx>]

Some annotation fixes were not applied both on declarations in .h files
and definitions in .c files.

Signed-off-by: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
---
 src/xenvif/frontend.h |  4 ++--
 src/xenvif/mac.h      |  4 ++--
 src/xenvif/parse.h    | 12 ++++++------
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/xenvif/frontend.h b/src/xenvif/frontend.h
index 4da8b3d..c2499ae 100644
--- a/src/xenvif/frontend.h
+++ b/src/xenvif/frontend.h
@@ -235,8 +235,8 @@ _IRQL_requires_max_(DISPATCH_LEVEL)
 extern NTSTATUS
 FrontendSetHashMapping(
     _Out_ PXENVIF_FRONTEND  Frontend,
-    _In_ PULONG             Mapping,
-    _In_ ULONG              Order
+    _In_reads_(Size) PULONG Mapping,
+    _In_ ULONG              Size
     );
 
 _IRQL_requires_max_(DISPATCH_LEVEL)
diff --git a/src/xenvif/mac.h b/src/xenvif/mac.h
index d407d1d..63a8e8e 100644
--- a/src/xenvif/mac.h
+++ b/src/xenvif/mac.h
@@ -104,13 +104,13 @@ MacDumpAddressTable(
 extern NTSTATUS
 MacAddMulticastAddress(
     _Out_ PXENVIF_MAC       Mac,
-    _Out_ PETHERNET_ADDRESS Address
+    _In_ PETHERNET_ADDRESS  Address
     );
 
 extern NTSTATUS
 MacRemoveMulticastAddress(
     _Out_ PXENVIF_MAC       Mac,
-    _Out_ PETHERNET_ADDRESS Address
+    _In_ PETHERNET_ADDRESS  Address
     );
 
 extern NTSTATUS
diff --git a/src/xenvif/parse.h b/src/xenvif/parse.h
index 6e5a260..642b32e 100644
--- a/src/xenvif/parse.h
+++ b/src/xenvif/parse.h
@@ -51,12 +51,12 @@ typedef BOOLEAN
 
 extern NTSTATUS
 ParsePacket(
-    _In_ PUCHAR                     StartVa,
-    _In_ ULONG                      StartLen,
-    _In_ XENVIF_PARSE_PULLUP        Pullup,
-    _In_ PVOID                      Argument,
-    _Inout_ PXENVIF_PACKET_PAYLOAD  Payload,
-    _Out_ PXENVIF_PACKET_INFO       Info
+    _Inout_updates_bytes_(StartLen) PUCHAR  StartVa,
+    _In_ ULONG                              StartLen,
+    _In_ XENVIF_PARSE_PULLUP                Pullup,
+    _In_ PVOID                              Argument,
+    _Inout_ PXENVIF_PACKET_PAYLOAD          Payload,
+    _Out_ PXENVIF_PACKET_INFO               Info
     );
 
 #endif  // _XENVIF_PARSE_H
-- 
2.55.0.windows.5



--
Césaire Mounah | Vates Windows Guest Tools Engineer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech