[PATCH 00/21] xenvif: update annotations to SAL 2.0

[Césaire Mounah <cesaire.mounah@xxxxxxxxxx>]

This patch series updates the xenvif driver to use SAL 2.0 annotations and 
fixes the issues found after code analysis.

It is organized into three parts: updating annotations to SAL 2.0, 
fixing annotation issues, and minor fixes after code analysis.

Part 1: Update annotations to SAL 2.0
* xenvif: sync common helper files from xeniface and xenbus
* xenvif: convert to SAL 2.0 annotations
* Update string typedefs

Part 2: Fix annotation issues
* xenvif: fix direction annotations on written parameters
* xenvif: Annotate unannotated functions
* xenvif: Annotate buffer and array parameters with their sizes
* driver: fix annotations on nullable parameters
* driver: fix Dispatch() annotation
* fdo: fix str annotation of __FdoMultiSzToUpcaseAnsi
* driver: fix annotation of __FdoEnumerate
* fdo: annotate macro-defined functions
* xenvif: fix inconsistent annotation between declarations and
    definitions
* settings: fix annotation of SettingsSave and SettingsRestore
* pdo: fix annotation of __PdoSetPower
* receiver: fix annotation errors:
* transmitter,controller: fix some annotations
* vif: fix the annotation of typedef XENVIF_VIF_CALLBACK
* controller: fix annotations

Part 3: Minor fixes after code analysis
* fdo: suppress uninitialized memory '*Interface'
* xenvif: Assert non-NULL pointers that code analysis cannot prove
* xenvif: Check the statistic name in frontend

Césaire Mounah (21):
  xenvif: sync common helper files from xeniface and xenbus
  xenvif: convert to SAL 2.0 annotations
  Update string typedefs
  xenvif: fix direction annotations on written parameters
  xenvif: Annotate unannotated functions
  xenvif: Annotate buffer and array parameters with their sizes
  driver: fix annotations on nullable parameters
  driver: fix Dispatch() annotation
  fdo: fix str annotation of __FdoMultiSzToUpcaseAnsi
  driver: fix annotation of __FdoEnumerate
  fdo: suppress uninitialized memory '*Interface'
  fdo: annotate macro-defined functions
  xenvif: fix inconsistent annotation between declarations and
    definitions
  settings: fix annotation of SettingsSave and SettingsRestore
  pdo: fix annotation of __PdoSetPower
  receiver: fix annotation errors:
  transmitter,controller: fix some annotations
  vif: fix the annotation of typedef XENVIF_VIF_CALLBACK
  xenvif: Assert non-NULL pointers that code analysis cannot prove
  xenvif: Check the statistic name in frontend
  controller: fix annotations

 include/cache_interface.h     | 130 ++++-----
 include/debug_interface.h     |  88 +++---
 include/evtchn_interface.h    | 136 ++++-----
 include/gnttab_interface.h    | 148 +++++-----
 include/range_set_interface.h |  38 +--
 include/store_interface.h     |  84 +++---
 include/suspend_interface.h   |  24 +-
 include/unplug_interface.h    |  20 +-
 include/vif_interface.h       | 158 +++++-----
 src/xenvif/assert.h           | 116 ++++----
 src/xenvif/bus.c              |  68 ++---
 src/xenvif/bus.h              |   6 +-
 src/xenvif/checksum.c         |  80 +++---
 src/xenvif/checksum.h         |  50 ++--
 src/xenvif/controller.c       | 146 +++++-----
 src/xenvif/controller.h       |  52 ++--
 src/xenvif/dbg_print.h        |  39 +--
 src/xenvif/driver.c           |  38 +--
 src/xenvif/fdo.c              | 525 +++++++++++++++++-----------------
 src/xenvif/fdo.h              |  70 ++---
 src/xenvif/frontend.c         | 296 +++++++++----------
 src/xenvif/frontend.h         | 104 +++----
 src/xenvif/link.c             |  14 +-
 src/xenvif/link.h             |   6 +-
 src/xenvif/mac.c              | 120 ++++----
 src/xenvif/mac.h              |  70 ++---
 src/xenvif/mrsw.h             |   6 +-
 src/xenvif/mutex.h            |  10 +-
 src/xenvif/names.h            |  60 ++--
 src/xenvif/parse.c            | 142 ++++-----
 src/xenvif/parse.h            |  20 +-
 src/xenvif/pdo.c              | 414 +++++++++++++--------------
 src/xenvif/pdo.h              |  96 +++----
 src/xenvif/receiver.c         | 434 ++++++++++++++--------------
 src/xenvif/receiver.h         |  64 ++---
 src/xenvif/registry.c         | 436 ++++++++++++++++++----------
 src/xenvif/registry.h         | 198 +++++++------
 src/xenvif/settings.c         |  78 ++---
 src/xenvif/settings.h         |  20 +-
 src/xenvif/thread.c           |  36 +--
 src/xenvif/thread.h           |  18 +-
 src/xenvif/transmitter.c      | 406 +++++++++++++-------------
 src/xenvif/transmitter.h      |  80 +++---
 src/xenvif/util.h             | 102 ++++---
 src/xenvif/vif.c              | 258 +++++++++--------
 src/xenvif/vif.h              |  48 ++--
 46 files changed, 2885 insertions(+), 2667 deletions(-)

-- 
2.55.0.windows.5



--
Césaire Mounah | Vates Windows Guest Tools Engineer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech