[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 10/21] driver: fix annotation of __FdoEnumerate


  • To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
  • Date: Mon, 12 Oct 2026 12:23:22 +0200
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID"
  • Cc: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
  • Delivery-date: Mon, 12 Oct 2026 10:23:55 +0000
  • Feedback-id: default:8631fc262581453bbf619ec5b2062170:Sweego
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>

__FdoEnumerate handles the case where Device param is set to NULL and
can be called with Devices set to NULL in a failure path of
FdoScan.
Device also has its Length param written to avoid duplication.
Annotate it as _Inout_opt_.

Signed-off-by: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
---
 src/xenvif/fdo.c | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/xenvif/fdo.c b/src/xenvif/fdo.c
index 99dce73..af8bec4 100644
--- a/src/xenvif/fdo.c
+++ b/src/xenvif/fdo.c
@@ -717,16 +717,16 @@ FdoReleaseMutex(
 
 static FORCEINLINE BOOLEAN
 __FdoEnumerate(
-    _In_ PXENVIF_FDO    Fdo,
-    _In_ PANSI_STRING   Devices
+    _In_ PXENVIF_FDO            Fdo,
+    _Inout_opt_ PANSI_STRING    Devices
     )
 {
-    BOOLEAN             NeedInvalidate;
-    HANDLE              ParametersKey;
-    ULONG               Enumerate;
-    PLIST_ENTRY         ListEntry;
-    ULONG               Index;
-    NTSTATUS            status;
+    BOOLEAN                     NeedInvalidate;
+    HANDLE                      ParametersKey;
+    ULONG                       Enumerate;
+    PLIST_ENTRY                 ListEntry;
+    ULONG                       Index;
+    NTSTATUS                    status;
 
     Trace("====>\n");
 
-- 
2.55.0.windows.5



--
Césaire Mounah | Vates Windows Guest Tools Engineer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.