[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH 21/21] controller: fix annotations


  • To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
  • From: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
  • Date: Mon, 12 Oct 2026 12:23:33 +0200
  • Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=vates.tech header.i="@vates.tech" header.h="From:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type:In-Reply-To:References:Feedback-ID"
  • Cc: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
  • Delivery-date: Mon, 12 Oct 2026 10:23:59 +0000
  • Feedback-id: default:8631fc262581453bbf619ec5b2062170:Sweego
  • List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>

__ControllerAcquire|ReleaseLock() are wrappers on KeAcquireSpinLockAtDpcLevel()
which argument is annotated as Inout.
Annotate Controller accordingly in these and related functions.

Signed-off-by: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
---
 src/xenvif/controller.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/xenvif/controller.c b/src/xenvif/controller.c
index 37d10c4..7a8b884 100644
--- a/src/xenvif/controller.c
+++ b/src/xenvif/controller.c
@@ -104,7 +104,7 @@ __ControllerFree(
 static FORCEINLINE VOID
 _IRQL_requires_(DISPATCH_LEVEL)
 __ControllerAcquireLock(
-    _Out_ PXENVIF_CONTROLLER    Controller
+    _Inout_ PXENVIF_CONTROLLER    Controller
     )
 {
     ASSERT3U(KeGetCurrentIrql(), ==, DISPATCH_LEVEL);
@@ -115,7 +115,7 @@ __ControllerAcquireLock(
 static FORCEINLINE VOID
 _IRQL_requires_(DISPATCH_LEVEL)
 __ControllerReleaseLock(
-    _Out_ PXENVIF_CONTROLLER    Controller
+    _Inout_ PXENVIF_CONTROLLER    Controller
     )
 {
     KeReleaseSpinLockFromDpcLevel(&Controller->Lock);
@@ -125,7 +125,7 @@ _Acquires_nonreentrant_lock_(Controller)
 _IRQL_requires_(DISPATCH_LEVEL)
 static VOID
 ControllerAcquireLock(
-    _Out_ PXENVIF_CONTROLLER    Controller
+    _Inout_ PXENVIF_CONTROLLER    Controller
     )
 {
     __ControllerAcquireLock(Controller);
@@ -135,7 +135,7 @@ _Requires_lock_held_(Controller)
 _IRQL_requires_(DISPATCH_LEVEL)
 static VOID
 ControllerReleaseLock(
-    _Out_ PXENVIF_CONTROLLER    Controller
+    _Inout_ PXENVIF_CONTROLLER    Controller
     )
 {
     __ControllerReleaseLock(Controller);
-- 
2.55.0.windows.5



--
Césaire Mounah | Vates Windows Guest Tools Engineer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.