[PATCH 17/21] transmitter,controller: fix some annotations

[Césaire Mounah <cesaire.mounah@xxxxxxxxxx>]

* In __TransmitterRequestMulticastControl, StorePrintf is called on Transaction
and Transaction is annotated there as _In_opt_ so we put the same annotation
to __TransmitterRequestMulticastControl to suppress warning on Transaction.

* KSERVICE_ROUTINE is already annotated in wdm.h,
TransmitterRingEvtchnCallback and ControllerEvtchnCallback are annotated to
use the same annotation with _Use_decl_annotations_ so we remove the
annotations in their parameters.

Signed-off-by: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
---
 src/xenvif/controller.c  |  4 ++--
 src/xenvif/transmitter.c | 14 +++++++-------
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/xenvif/controller.c b/src/xenvif/controller.c
index 95fdae6..37d10c4 100644
--- a/src/xenvif/controller.c
+++ b/src/xenvif/controller.c
@@ -354,8 +354,8 @@ KSERVICE_ROUTINE    ControllerEvtchnCallback;
 _Use_decl_annotations_
 BOOLEAN
 ControllerEvtchnCallback(
-    _In_ PKINTERRUPT            InterruptObject,
-    _In_ PVOID                  Argument
+    PKINTERRUPT                 InterruptObject,
+    PVOID                       Argument
     )
 {
     PXENVIF_CONTROLLER          Controller = Argument;
diff --git a/src/xenvif/transmitter.c b/src/xenvif/transmitter.c
index aff06b7..3263089 100644
--- a/src/xenvif/transmitter.c
+++ b/src/xenvif/transmitter.c
@@ -3303,8 +3303,8 @@ KSERVICE_ROUTINE    TransmitterRingEvtchnCallback;
 _Use_decl_annotations_
 BOOLEAN
 TransmitterRingEvtchnCallback(
-    _In_ PKINTERRUPT            InterruptObject,
-    _In_ PVOID                  Argument
+    PKINTERRUPT                 InterruptObject,
+    PVOID                       Argument
     )
 {
     PXENVIF_TRANSMITTER_RING    Ring = Argument;
@@ -4803,13 +4803,13 @@ fail1:
 _IRQL_requires_(DISPATCH_LEVEL)
 static FORCEINLINE NTSTATUS
 __TransmitterRequestMulticastControl(
-    _In_ PXENVIF_TRANSMITTER        Transmitter,
-    _In_ PXENBUS_STORE_TRANSACTION  Transaction,
-    _In_ BOOLEAN                    Enabled
+    _In_ PXENVIF_TRANSMITTER            Transmitter,
+    _In_opt_ PXENBUS_STORE_TRANSACTION  Transaction,
+    _In_ BOOLEAN                        Enabled
     )
 {
-    PXENVIF_FRONTEND                Frontend;
-    NTSTATUS                        status;
+    PXENVIF_FRONTEND                    Frontend;
+    NTSTATUS                            status;
 
     Frontend = Transmitter->Frontend;
 
-- 
2.55.0.windows.5



--
Césaire Mounah | Vates Windows Guest Tools Engineer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech