[PATCH 16/21] receiver: fix annotation errors:

[Césaire Mounah <cesaire.mounah@xxxxxxxxxx>]

* KSERVICE_ROUTINE is already annotated in wdm.h and
ReceiverRingEvtchnCallback() reuse it with _Use_decl_annotations_ so no need
to re-annotate it.

* __ReceiverRingTeardown and ReceiverRingTeardown read the Ring param before
updating it, so Ring should be annotated as _Inout_ in both cases.

Signed-off-by: Césaire Mounah <cesaire.mounah@xxxxxxxxxx>
---
 src/xenvif/receiver.c | 18 +++++++++---------
 src/xenvif/receiver.h |  2 +-
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/xenvif/receiver.c b/src/xenvif/receiver.c
index b25d84d..68c2288 100644
--- a/src/xenvif/receiver.c
+++ b/src/xenvif/receiver.c
@@ -2335,13 +2335,13 @@ KSERVICE_ROUTINE    ReceiverRingEvtchnCallback;
 _Use_decl_annotations_
 BOOLEAN
 ReceiverRingEvtchnCallback(
-    _In_ PKINTERRUPT            InterruptObject,
-    _In_ PVOID                  Argument
+    PKINTERRUPT            InterruptObject,
+    PVOID                  Argument
     )
 {
-    PXENVIF_RECEIVER_RING       Ring = Argument;
-    PXENVIF_RECEIVER            Receiver;
-    PXENVIF_FRONTEND            Frontend;
+    PXENVIF_RECEIVER_RING  Ring = Argument;
+    PXENVIF_RECEIVER       Receiver;
+    PXENVIF_FRONTEND       Frontend;
 
     UNREFERENCED_PARAMETER(InterruptObject);
 
@@ -2992,7 +2992,7 @@ __ReceiverRingDisconnect(
 
 static FORCEINLINE VOID
 __ReceiverRingTeardown(
-    _Out_ PXENVIF_RECEIVER_RING Ring
+    _Inout_ PXENVIF_RECEIVER_RING Ring
     )
 {
     PXENVIF_RECEIVER            Receiver;
@@ -3649,11 +3649,11 @@ ReceiverDisconnect(
 _IRQL_requires_(PASSIVE_LEVEL)
 VOID
 ReceiverTeardown(
-    _Out_ PXENVIF_RECEIVER  Receiver
+    _Inout_ PXENVIF_RECEIVER    Receiver
     )
 {
-    PXENVIF_FRONTEND        Frontend;
-    LONG                    Index;
+    PXENVIF_FRONTEND            Frontend;
+    LONG                        Index;
 
     Frontend = Receiver->Frontend;
 
diff --git a/src/xenvif/receiver.h b/src/xenvif/receiver.h
index d2b86fa..de00995 100644
--- a/src/xenvif/receiver.h
+++ b/src/xenvif/receiver.h
@@ -82,7 +82,7 @@ ReceiverDisconnect(
 _IRQL_requires_(PASSIVE_LEVEL)
 extern VOID
 ReceiverTeardown(
-    _Out_ PXENVIF_RECEIVER  Receiver
+    _Inout_ PXENVIF_RECEIVER    Receiver
     );
 
 _IRQL_requires_max_(APC_LEVEL)
-- 
2.55.0.windows.5



--
Césaire Mounah | Vates Windows Guest Tools Engineer

XCP-ng & Xen Orchestra - Vates solutions

web: https://vates.tech