[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/4] gnttab: Don't free resources through an ASSERT
- To: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>, "win-pv-devel@xxxxxxxxxxxxxxxxxxxx" <win-pv-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Owen Smith <owen.smith@xxxxxxxxxx>
- Date: Tue, 13 Oct 2026 12:57:00 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1roS/X8zXNI3sDyrQDHenbWI8SuCQBkKQa7JrPrjHa0=; b=ofLLGadd+NDWpUf3hkiT6DlRSj6HBPNcXU14JQFv8cxk/PHPyB0yYF7GNx4wyfDeUlyfiROQC15ds0f3h5sX3K6Zb2gxqfGHcwXr+CE4ZeM1+BJZBEN8mGH2DyMRVZZRsCy14IVeI3ohJhyF/XxGas2hwZ1BV7LQKas9GLsOxVABEhHS5N4zgPyxJDwzWeZFHEElqQL9oF6OPJiBIm7ok4HyJ6/QFP6QCgLGKhG4Sem6/GuVqP1mvhHm9SuNKGAcDPSSWtmKHak/8azPSuFpyZjN82fRezKfP10YL0jbRHBjnhtWxhyfQkpNBOaS3roWsILvTwy7wpnALxeUf1SHCA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RWjG+YcnrKw1Ej+2CWorz7WUOH5fSORElqFh15aXRCXWo1a9RkFBmfj5f0ZdqzcvffIkCc9x7VssoM6r4EVDAJAlZg4fKEFb4dGxnNm95kwRBQv03ZV7GHNIoOaazyCLB344xOrKykxSF2WH4Remrp/Uz8c3ErVb057BKgUbDaUFOR46KPiemGkh8OOMPPUURrm3l4JZPxyHAzKuT/3yRm011NzmR3yx3W1oVdI91723hm5YGiiOX/CbtP22JdmAvq9zOK5lcKWqe3IeeOtVSrSw2IJm1u5T/o3LPGkkwhk17UgCZwEzsMpiNo919f9NANNU1k4lRcbdfnM4cbsuJw==
- Authentication-results: eu.smtp.expurgate.cloud; dkim=pass header.s=selector1 header.d=citrix.com header.i="@citrix.com" header.h="From:Date:Subject:Message-ID:Content-Type:MIME-Version:x-ms-exchange-senderadcheck"
- Authentication-results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Delivery-date: Tue, 13 Oct 2026 12:57:06 +0000
- List-id: Developer list for the Windows PV Drivers subproject <win-pv-devel.lists.xenproject.org>
- Msip_labels:
- Thread-index: AQHdWw7Y7AK1x+NTrU236ercBDKk9rb7aEIAgAAFhD8=
- Thread-topic: [PATCH 1/4] gnttab: Don't free resources through an ASSERT
These 4 patches, on top of David's first 9 patches
Reviewed-by: Owen Smith <owen.smith@xxxxxxxxxx>
________________________________________
From: win-pv-devel <win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx> on behalf of Tu
Dinh <ngoc-tu.dinh@xxxxxxxxxx>
Sent: 13 October 2026 1:34 PM
To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH 1/4] gnttab: Don't free resources through an ASSERT
On 13/10/2026 14:32, Tu Dinh wrote:
> ASSERT macros skip evaluating their contents, so calling e.g.
> RevokeForeignAccess inside an ASSERT will end up causing the call to be
> skipped in release builds.
>
> Signed-off-by: Tu Dinh <ngoc-tu.dinh@xxxxxxxxxx>
These 4 patches are meant to be applied on top of David's 10-patch
series and tested in that context.
--
Ngoc Tu Dinh | Vates XCP-ng Developer
XCP-ng & Xen Orchestra - Vates solutions
web: https://vates.tech
|
