[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen stable-4.2] x86/EFI: permit setting variable with non-zero attributes



commit 8d870e41ed8cd624c5390530ca5bf32dc267cb7f
Author:     Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Tue Apr 2 11:23:05 2013 +0200
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Tue Apr 2 11:23:05 2013 +0200

    x86/EFI: permit setting variable with non-zero attributes
    
    This must have been a copy-and-paste mistake - get_variable uses
    op->misc as output only, and wants to make sure it's zero for future
    extensibility. For set_variable, this is an input though, and hence
    the check is wrong.
    
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Acked-by: Keir Fraser <keir@xxxxxxx>
    master changeset: 78380c34dfeb27da3d0222bcb7232c5d8e2f5b30
    master date: 2013-03-27 08:46:28 +0100
---
 xen/arch/x86/efi/runtime.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/xen/arch/x86/efi/runtime.c b/xen/arch/x86/efi/runtime.c
index 1dbe2db..9fbf5b7 100644
--- a/xen/arch/x86/efi/runtime.c
+++ b/xen/arch/x86/efi/runtime.c
@@ -380,9 +380,6 @@ int efi_runtime_call(struct xenpf_efi_runtime_call *op)
         long len;
         unsigned char *data;
 
-        if ( op->misc )
-            return -EINVAL;
-
         len = gwstrlen(guest_handle_cast(op->u.set_variable.name, CHAR16));
         if ( len < 0 )
             return len;
--
generated by git-patchbot for /home/xen/git/xen.git#stable-4.2

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.