[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen master] xen: arm: enable aborts on all physical processors.



commit bbccf0d088d2041d95ede1d59fc195205f932f38
Author:     Ian Campbell <ian.campbell@xxxxxxxxxx>
AuthorDate: Thu Apr 25 15:45:50 2013 +0100
Commit:     Ian Campbell <ian.campbell@xxxxxxxxxx>
CommitDate: Fri Jul 19 14:53:46 2013 +0100

    xen: arm: enable aborts on all physical processors.
    
    I'm not sure how this ended up in construct dom0 where it only affects the
    boot cpu and doesn't logically fit.
    
    Enable aborts at the same time as we enable interrupts.
    
    I'm not sure what the behaviour of an "abort worthy" operation while aborts
    are disable is, but it must surely be worse than calling do_unexpected_trap,
    which is what happens from now on.
    
    Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
    Acked-by: Tim Deegan <tim@xxxxxxx>
---
 xen/arch/arm/domain_build.c |    2 --
 xen/arch/arm/setup.c        |    1 +
 xen/arch/arm/smpboot.c      |    1 +
 3 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/xen/arch/arm/domain_build.c b/xen/arch/arm/domain_build.c
index 0423b5a..155b436 100644
--- a/xen/arch/arm/domain_build.c
+++ b/xen/arch/arm/domain_build.c
@@ -633,8 +633,6 @@ int construct_dom0(struct domain *d)
         }
     }
 
-    local_abort_enable();
-
     return 0;
 }
 
diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
index c22972f..2f9fdc8 100644
--- a/xen/arch/arm/setup.c
+++ b/xen/arch/arm/setup.c
@@ -488,6 +488,7 @@ void __init start_xen(unsigned long boot_phys_offset,
     arch_init_memory();
 
     local_irq_enable();
+    local_abort_enable();
 
     smp_prepare_cpus(cpus);
 
diff --git a/xen/arch/arm/smpboot.c b/xen/arch/arm/smpboot.c
index c7421fc..5895178 100644
--- a/xen/arch/arm/smpboot.c
+++ b/xen/arch/arm/smpboot.c
@@ -175,6 +175,7 @@ void __cpuinit start_secondary(unsigned long 
boot_phys_offset,
     wmb();
 
     local_irq_enable();
+    local_abort_enable();
 
     printk(XENLOG_DEBUG "CPU %u booted.\n", smp_processor_id());
 
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.