[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-changelog] [xen master] xen: arm: drop LDFLAGS_DIRECT emulation specification.
commit 2a6327bf2bfaf5de5e07aed583d2c337c9d368c0 Author: Ian Campbell <ian.campbell@xxxxxxxxxx> AuthorDate: Fri Apr 26 11:58:47 2013 +0100 Commit: Ian Campbell <ian.campbell@xxxxxxxxxx> CommitDate: Fri Jul 19 14:56:42 2013 +0100 xen: arm: drop LDFLAGS_DIRECT emulation specification. The current -maarch64elf fails when cross-building arm64 on Ubuntu Raring due to a missing file "ldscripts/aarch64elf.xr". This is undoubtedly an Ubuntu gcc bug, hwever when investigating I found that this option was not necessary at all since we provide an explicit linker script when linking the hypervisor (AFAICT all -m<foo> does is override the default linker script). LDFLAGS_DIRECT is also used when linking the intermediate built-in.o files but -m<emulatin> is not needed for this since it isn't linking the final image and we are calling the linker with the correct, cross if necessary, name. However it does appear to be potentially useful to supply -EL in both cases to ensure that we get little endian images. (I just happened to spot that Linux does this, for both arm and arm64, although I expect we are unlikely to trip over such toolchains these days). Tested with cross-builds of arm32 and arm64 as well as a native arm32 build. Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx> Acked-by: Tim Deegan <tim@xxxxxxx> --- config/arm32.mk | 5 +---- config/arm64.mk | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/config/arm32.mk b/config/arm32.mk index 3bc642d..8e21158 100644 --- a/config/arm32.mk +++ b/config/arm32.mk @@ -13,9 +13,6 @@ HAS_PL011 := y HAS_EXYNOS4210 := y # Use only if calling $(LD) directly. -#LDFLAGS_DIRECT_OpenBSD = _obsd -#LDFLAGS_DIRECT_FreeBSD = _fbsd -LDFLAGS_DIRECT_Linux = _linux -LDFLAGS_DIRECT += -marmelf$(LDFLAGS_DIRECT_$(XEN_OS))_eabi +LDFLAGS_DIRECT += -EL CONFIG_LOAD_ADDRESS ?= 0x80000000 diff --git a/config/arm64.mk b/config/arm64.mk index 1130630..49055fa 100644 --- a/config/arm64.mk +++ b/config/arm64.mk @@ -9,6 +9,6 @@ CFLAGS += #-marm -march= -mcpu= etc HAS_PL011 := y # Use only if calling $(LD) directly. -LDFLAGS_DIRECT += -maarch64elf +LDFLAGS_DIRECT += -EL CONFIG_LOAD_ADDRESS ?= 0x80000000 -- generated by git-patchbot for /home/xen/git/xen.git#master _______________________________________________ Xen-changelog mailing list Xen-changelog@xxxxxxxxxxxxx http://lists.xensource.com/xen-changelog
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |