[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-changelog] [xen master] tools/symbols: document binutils commits for issues needing workarounds so far



commit d87b78cfe65a1eecfe75dc86037f19b2cd7b1f6a
Author:     Jan Beulich <jbeulich@xxxxxxxx>
AuthorDate: Wed Dec 16 12:00:25 2015 +0100
Commit:     Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Wed Dec 16 12:00:25 2015 +0100

    tools/symbols: document binutils commits for issues needing workarounds so 
far
    
    Also the issue 3rd issue mentioned in commit d37d63d4b5 ("symbols:
    prefix static symbols with their source file names") has been fixed by
    binutils commit 270f824531 (also expected to appear in 2.27).
    
    Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
    Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
---
 xen/tools/symbols.c |   15 +++++++++------
 1 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/xen/tools/symbols.c b/xen/tools/symbols.c
index 1abdf08..196db74 100644
--- a/xen/tools/symbols.c
+++ b/xen/tools/symbols.c
@@ -105,15 +105,18 @@ static int read_symbol(FILE *in, struct sym_entry *s)
 
        sym = strrchr(str, '.');
        if (strcasecmp(type, "FILE") == 0 ||
-           (/* GNU nm prior to XXX doesn't produce a type for EFI binaries. */
+           (/*
+             * GNU nm prior to binutils commit 552e55ed06 (expected to
+             * appear in 2.27) doesn't produce a type for EFI binaries.
+             */
             input_format == fmt_sysv && !*type && stype == '?' && sym &&
             sym[1] && strchr("cSsoh", sym[1]) && !sym[2])) {
                /*
-                * gas prior to XXX outputs symbol table entries resulting
-                * from .file in reverse order. If we get two consecutive file
-                * symbols, prefer the first one if that names an object file
-                * or has a directory component (to cover multiply compiled
-                * files).
+                * gas prior to binutils commit fbdf9406b0 (expected to appear
+                * in 2.27) outputs symbol table entries resulting from .file
+                * in reverse order. If we get two consecutive file symbols,
+                * prefer the first one if that names an object file or has a
+                * directory component (to cover multiply compiled files).
                 */
                bool multi = strchr(str, '/') || (sym && sym[1] == 'o');
 
--
generated by git-patchbot for /home/xen/git/xen.git#master

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.