|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-changelog] [xen stable-4.8] x86/mce: make 'severity_cpu' private to its users
commit 1780c265f7eaf904945884e755e7c7902e4c2132
Author: Haozhong Zhang <haozhong.zhang@xxxxxxxxx>
AuthorDate: Wed May 3 17:06:07 2017 +0200
Commit: Jan Beulich <jbeulich@xxxxxxxx>
CommitDate: Wed May 3 17:06:07 2017 +0200
x86/mce: make 'severity_cpu' private to its users
The current 'severity_cpu' is used by both mcheck_cmn_handler() and
mce_softirq(). If MC# happens during mce_softirq(), the values set in
mcheck_cmn_handler() and mce_softirq() may interfere with each
other. Use private 'severity_cpu' for each function to fix this issue.
Signed-off-by: Haozhong Zhang <haozhong.zhang@xxxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
master commit: 011899a2e00b9f748c04d501c205da04bbff4359
master date: 2017-04-07 15:55:34 +0200
---
xen/arch/x86/cpu/mcheck/mce.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/xen/arch/x86/cpu/mcheck/mce.c b/xen/arch/x86/cpu/mcheck/mce.c
index 2695b0c..ba79e67 100644
--- a/xen/arch/x86/cpu/mcheck/mce.c
+++ b/xen/arch/x86/cpu/mcheck/mce.c
@@ -186,7 +186,6 @@ static struct mce_softirq_barrier mce_trap_bar;
*/
static DEFINE_SPINLOCK(mce_logout_lock);
-static atomic_t severity_cpu = ATOMIC_INIT(-1);
static atomic_t found_error = ATOMIC_INIT(0);
static cpumask_t mce_fatal_cpus;
@@ -464,6 +463,7 @@ static int mce_urgent_action(const struct cpu_user_regs
*regs,
/* Shared #MC handler. */
void mcheck_cmn_handler(const struct cpu_user_regs *regs)
{
+ static atomic_t severity_cpu = ATOMIC_INIT(-1);
struct mca_banks *bankmask = mca_allbanks;
struct mca_banks *clear_bank = __get_cpu_var(mce_clear_banks);
uint64_t gstatus;
@@ -1719,6 +1719,7 @@ static int mce_delayed_action(mctelem_cookie_t mctc)
/* Softirq Handler for this MCE# processing */
static void mce_softirq(void)
{
+ static atomic_t severity_cpu;
int cpu = smp_processor_id();
unsigned int workcpu;
--
generated by git-patchbot for /home/xen/git/xen.git#stable-4.8
_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |