[Xen-changelog] [xen staging] arm/irq: skip action availability check for non-debug build

[patchbot@xxxxxxx]

commit d48ef111c781d9bb7740264f6481cc2412093993
Author:     Andrii Anisov <andrii_anisov@xxxxxxxx>
AuthorDate: Wed Dec 12 20:20:55 2018 +0200
Commit:     Julien Grall <julien.grall@xxxxxxx>
CommitDate: Fri Dec 14 15:25:35 2018 +0000

    arm/irq: skip action availability check for non-debug build
    
    Under desc->lock taken:
    An IRQ with _IRQ_GUEST flag set always has an action.
    An IRQ with _IRQ_DISABLED flag cleared always has an action.
    Those flags checks cover all accesses to desc->action in do_IRQ,
    so we can skip desc->action check in non-debug build.
    Keep in place for debug build to help diagnostics potential
    misconfiguration.
    
    Signed-off-by: Andrii Anisov <andrii_anisov@xxxxxxxx>
    Acked-by: Julien Grall <julien.grall@xxxxxxx>
---
 xen/arch/arm/irq.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c
index d6a0273d7a..4a02cc1eba 100644
--- a/xen/arch/arm/irq.c
+++ b/xen/arch/arm/irq.c
@@ -209,12 +209,14 @@ void do_IRQ(struct cpu_user_regs *regs, unsigned int irq, 
int is_fiq)
     spin_lock(&desc->lock);
     desc->handler->ack(desc);
 
+#ifndef NDEBUG
     if ( !desc->action )
     {
         printk("Unknown %s %#3.3x\n",
                is_fiq ? "FIQ" : "IRQ", irq);
         goto out;
     }
+#endif
 
     if ( test_bit(_IRQ_GUEST, &desc->status) )
     {
--
generated by git-patchbot for /home/xen/git/xen.git#staging

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/xen-changelog