[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [Xen-changelog] [xen staging] xen/cpu: Fix ARM build following c/s 597fbb8
commit a6448adfd3d537aacbbd784e5bf1777ab3ff5f85 Author: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> AuthorDate: Mon Apr 8 18:20:07 2019 +0100 Commit: Wei Liu <wei.liu2@xxxxxxxxxx> CommitDate: Tue Apr 9 10:12:57 2019 +0100 xen/cpu: Fix ARM build following c/s 597fbb8 c/s 597fbb8 "xen/timers: Fix memory leak with cpu unplug/plug" broke the ARM build by being the first patch to add park_offline_cpus to common code. While it is currently specific to Intel hardware (for reasons of being able to handle machine check exceptions without an immediate system reset), it isn't inherently architecture specific, so define it to be false on ARM for now. Add a comment in both smp.h headers explaining the intended behaviour of the option. Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Reviewed-by: Julien Grall <julien.grall@xxxxxxx> Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx> --- xen/include/asm-arm/smp.h | 6 ++++++ xen/include/asm-x86/smp.h | 4 ++++ 2 files changed, 10 insertions(+) diff --git a/xen/include/asm-arm/smp.h b/xen/include/asm-arm/smp.h index 3c122681d7..fdbcefa241 100644 --- a/xen/include/asm-arm/smp.h +++ b/xen/include/asm-arm/smp.h @@ -14,6 +14,12 @@ DECLARE_PER_CPU(cpumask_var_t, cpu_core_mask); #define raw_smp_processor_id() (get_processor_id()) +/* + * Do we, for platform reasons, need to actually keep CPUs online when we + * would otherwise prefer them to be off? + */ +#define park_offline_cpus false + extern void noreturn stop_cpu(void); extern int arch_smp_init(void); diff --git a/xen/include/asm-x86/smp.h b/xen/include/asm-x86/smp.h index 09c55458df..9f533f9072 100644 --- a/xen/include/asm-x86/smp.h +++ b/xen/include/asm-x86/smp.h @@ -26,6 +26,10 @@ DECLARE_PER_CPU(cpumask_var_t, cpu_sibling_mask); DECLARE_PER_CPU(cpumask_var_t, cpu_core_mask); DECLARE_PER_CPU(cpumask_var_t, scratch_cpumask); +/* + * Do we, for platform reasons, need to actually keep CPUs online when we + * would otherwise prefer them to be off? + */ extern bool park_offline_cpus; void smp_send_nmi_allbutself(void); -- generated by git-patchbot for /home/xen/git/xen.git#staging _______________________________________________ Xen-changelog mailing list Xen-changelog@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/xen-changelog
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |