[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[qemu-xen staging] target/xtensa: drop gen_io_end call



commit 8a3a81478dcc592518069125a6ad271fe5511b95
Author:     Max Filippov <jcmvbkbc@xxxxxxxxx>
AuthorDate: Sun Jun 21 22:26:50 2020 -0700
Commit:     Max Filippov <jcmvbkbc@xxxxxxxxx>
CommitDate: Mon Jun 22 03:38:30 2020 -0700

    target/xtensa: drop gen_io_end call
    
    Since commit
    ba3e7926691e ("icount: clean up cpu_can_io at the entry to the block")
    it has been unnecessary for target code to call gen_io_end() after an IO
    instruction in icount mode; it is sufficient to call gen_io_start()
    before it and to force the end of the TB.
    Remaining call in xtensa target translator is for the opcodes that may
    change IRQ state. All of them end current TB, so gen_io_end is not
    needed. Drop gen_io_end call from the xtensa target translator.
    
    Signed-off-by: Max Filippov <jcmvbkbc@xxxxxxxxx>
    Reviewed-by: Peter Maydell <peter.maydell@xxxxxxxxxx>
---
 target/xtensa/translate.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/target/xtensa/translate.c b/target/xtensa/translate.c
index 4bc15252c8..6346b2eef0 100644
--- a/target/xtensa/translate.c
+++ b/target/xtensa/translate.c
@@ -595,9 +595,6 @@ static int gen_postprocess(DisasContext *dc, int slot)
             gen_io_start();
         }
         gen_helper_check_interrupts(cpu_env);
-        if (tb_cflags(dc->base.tb) & CF_USE_ICOUNT) {
-            gen_io_end();
-        }
     }
 #endif
     if (op_flags & XTENSA_OP_SYNC_REGISTER_WINDOW) {
--
generated by git-patchbot for /home/xen/git/qemu-xen.git#staging



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.