[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] xen/arm64: Fix incorrect DIRECTMAP_SIZE calculation



commit 1b9d4ec26b01c5cde17153b27f1038a24e6d8b27
Author:     Michal Orzel <michal.orzel@xxxxxxx>
AuthorDate: Tue Jan 17 12:43:30 2023 +0100
Commit:     Julien Grall <jgrall@xxxxxxxxxx>
CommitDate: Fri Jan 20 13:44:05 2023 +0000

    xen/arm64: Fix incorrect DIRECTMAP_SIZE calculation
    
    The direct mapped area occupies L0 slots from 256 to 265 included
    (i.e. 10 slots), resulting in 5TB (512GB * 10) of virtual address space.
    However, due to incorrect slot subtraction (we take 9 slots into account)
    we set DIRECTMAP_SIZE to 4.5TB instead. Fix it.
    
    Note that we only support up to 2TB of physical memory so this is
    a latent issue.
    
    Fixes: 5263507b1b4a ("xen: arm: Use a direct mapping of RAM on arm64")
    Signed-off-by: Michal Orzel <michal.orzel@xxxxxxx>
    Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
---
 xen/arch/arm/include/asm/config.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/arch/arm/include/asm/config.h 
b/xen/arch/arm/include/asm/config.h
index 0fefed1b8a..16213c8b67 100644
--- a/xen/arch/arm/include/asm/config.h
+++ b/xen/arch/arm/include/asm/config.h
@@ -157,7 +157,7 @@
 #define FRAMETABLE_NR          (FRAMETABLE_SIZE / sizeof(*frame_table))
 
 #define DIRECTMAP_VIRT_START   SLOT0(256)
-#define DIRECTMAP_SIZE         (SLOT0_ENTRY_SIZE * (265-256))
+#define DIRECTMAP_SIZE         (SLOT0_ENTRY_SIZE * (266 - 256))
 #define DIRECTMAP_VIRT_END     (DIRECTMAP_VIRT_START + DIRECTMAP_SIZE - 1)
 
 #define XENHEAP_VIRT_START     directmap_virt_start
--
generated by git-patchbot for /home/xen/git/xen.git#master



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.