[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [xen master] x86/asm: ELF metadata for simple cases
commit 9afcf3046b0fd3e52553aece191c34ca20115145 Author: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> AuthorDate: Mon Feb 20 11:04:39 2023 +0000 Commit: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> CommitDate: Fri Feb 24 17:44:29 2023 +0000 x86/asm: ELF metadata for simple cases This is generally good practice, and necessary for livepatch binary diffing to work. With this, livepatching of the SVM entry path works. The only complication is with svm_stgi_label which is only used by oprofile to guestimate (not completely correctly) when an NMI hit guest context. Livepatching of VMX is still an open question, because the logic doesn't form anything remotely resembling functions. Both code fragments jump into each other so need to be updated in tandem. Also, both code fragment entries need trampolines in the case that patching actually occurs. For now, just treat it as a single function. Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Acked-by: Jan Beulich <jbeulich@xxxxxxxx> --- xen/arch/x86/clear_page.S | 3 +++ xen/arch/x86/copy_page.S | 3 +++ xen/arch/x86/hvm/svm/entry.S | 3 +++ xen/arch/x86/hvm/vmx/entry.S | 3 +++ 4 files changed, 12 insertions(+) diff --git a/xen/arch/x86/clear_page.S b/xen/arch/x86/clear_page.S index d9d524c79e..5b5622cc52 100644 --- a/xen/arch/x86/clear_page.S +++ b/xen/arch/x86/clear_page.S @@ -16,3 +16,6 @@ ENTRY(clear_page_sse2) sfence ret + + .type clear_page_sse2, @function + .size clear_page_sse2, . - clear_page_sse2 diff --git a/xen/arch/x86/copy_page.S b/xen/arch/x86/copy_page.S index 2da81126c5..ddb6e0ebbb 100644 --- a/xen/arch/x86/copy_page.S +++ b/xen/arch/x86/copy_page.S @@ -41,3 +41,6 @@ ENTRY(copy_page_sse2) sfence ret + + .type copy_page_sse2, @function + .size copy_page_sse2, . - copy_page_sse2 diff --git a/xen/arch/x86/hvm/svm/entry.S b/xen/arch/x86/hvm/svm/entry.S index ad582f54b3..9effd2199b 100644 --- a/xen/arch/x86/hvm/svm/entry.S +++ b/xen/arch/x86/hvm/svm/entry.S @@ -139,3 +139,6 @@ GLOBAL(svm_stgi_label) sti call do_softirq jmp .Lsvm_do_resume + + .type svm_asm_do_resume, @function + .size svm_asm_do_resume, . - svm_asm_do_resume diff --git a/xen/arch/x86/hvm/vmx/entry.S b/xen/arch/x86/hvm/vmx/entry.S index 5f5de45a13..e3f60d5a82 100644 --- a/xen/arch/x86/hvm/vmx/entry.S +++ b/xen/arch/x86/hvm/vmx/entry.S @@ -150,3 +150,6 @@ ENTRY(vmx_asm_do_vmentry) sti call do_softirq jmp .Lvmx_do_vmentry + + .type vmx_asm_vmexit_handler, @function + .size vmx_asm_vmexit_handler, . - vmx_asm_vmexit_handler -- generated by git-patchbot for /home/xen/git/xen.git#master
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |