[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] tools/libs/store: make libxenstore independent of utils.h



commit 1a0342507cb4011607673efec13a8f3238ac6aa8
Author:     Juergen Gross <jgross@xxxxxxxx>
AuthorDate: Tue May 30 10:54:13 2023 +0200
Commit:     Julien Grall <julien@xxxxxxx>
CommitDate: Mon Jun 12 22:37:22 2023 +0100

    tools/libs/store: make libxenstore independent of utils.h
    
    There is no real need for including tools/xenstore/utils.h from
    libxenstore, as only streq() and ARRAY_SIZE() are obtained via that
    header.
    
    streq() is just !strcmp(), and ARRAY_SIZE() is brought in via
    xen-tools/common-macros.h.
    
    Signed-off-by: Juergen Gross <jgross@xxxxxxxx>
    Acked-by: Julien Grall <jgrall@xxxxxxxxxx>
---
 tools/libs/store/xs.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/libs/store/xs.c b/tools/libs/store/xs.c
index 3813b69ae2..76ffb1be45 100644
--- a/tools/libs/store/xs.c
+++ b/tools/libs/store/xs.c
@@ -33,9 +33,9 @@
 #include <signal.h>
 #include <stdint.h>
 #include <errno.h>
+#include <xen-tools/common-macros.h>
 #include "xenstore.h"
 #include "xs_lib.h"
-#include "utils.h"
 
 #include <xentoolcore_internal.h>
 #include <xen_list.h>
@@ -437,7 +437,7 @@ static int get_error(const char *errorstring)
 {
        unsigned int i;
 
-       for (i = 0; !streq(errorstring, xsd_errors[i].errstring); i++)
+       for (i = 0; strcmp(errorstring, xsd_errors[i].errstring); i++)
                if (i == ARRAY_SIZE(xsd_errors) - 1)
                        return EINVAL;
        return xsd_errors[i].errnum;
--
generated by git-patchbot for /home/xen/git/xen.git#master



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.