[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen master] tools/xenstored: Correct the prototype of domain_max_chk()



commit 128557e3a44d79f0c9360dc88e42c3d0ef728edf
Author:     Julien Grall <jgrall@xxxxxxxxxx>
AuthorDate: Mon Jun 12 11:13:19 2023 +0100
Commit:     Julien Grall <julien@xxxxxxx>
CommitDate: Mon Jun 12 22:38:13 2023 +0100

    tools/xenstored: Correct the prototype of domain_max_chk()
    
    Some version of GCC will complain because the prototype and the
    declaration of domain_max_chk() don't match:
    
    xenstored_domain.c:1503:6: error: conflicting types for 'domain_max_chk' 
due to enum/integer mismatch; have '_Bool(const struct connection *, enum 
accitem,  unsigned int)' [-Werror=enum-int-mismatch]
     1503 | bool domain_max_chk(const struct connection *conn, enum accitem 
what,
          |      ^~~~~~~~~~~~~~
    In file included from xenstored_domain.c:31:
    xenstored_domain.h:146:6: note: previous declaration of 'domain_max_chk' 
with type '_Bool(const struct connection *, unsigned int,  unsigned int)'
      146 | bool domain_max_chk(const struct connection *conn, unsigned int 
what,
          |      ^~~~~~~~~~~~~~
    
    Update the prototype to match the declaration.
    
    This was spotted by Gitlab CI with the job opensuse-tumbleweed-gcc.
    
    Fixes: 685048441e1c ("tools/xenstore: switch quota management to be table 
based")
    Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
    Reviewed-by: Jason Andryuk <jandryuk@xxxxxxxxx>
    Tested-by: Jason Andryuk <jandryuk@xxxxxxxxx>
    Reviewed-by: Juergen Gross <jgross@xxxxxxxx>
---
 tools/xenstore/xenstored_domain.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/xenstore/xenstored_domain.h 
b/tools/xenstore/xenstored_domain.h
index bf63f3fcc6..4950b00aee 100644
--- a/tools/xenstore/xenstored_domain.h
+++ b/tools/xenstore/xenstored_domain.h
@@ -143,7 +143,7 @@ void acc_drop(struct connection *conn);
 void acc_commit(struct connection *conn);
 int domain_max_global_acc(const void *ctx, struct connection *conn);
 void domain_reset_global_acc(void);
-bool domain_max_chk(const struct connection *conn, unsigned int what,
+bool domain_max_chk(const struct connection *conn, enum accitem what,
                    unsigned int val);
 
 extern long wrl_ntransactions;
--
generated by git-patchbot for /home/xen/git/xen.git#master



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.