[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[xen staging-4.18] tools/libxl: do not use `-c -E` compiler options together



commit 668e175d43b0b3109ba887789728b77d02750ffa
Author:     Roger Pau Monne <roger.pau@xxxxxxxxxx>
AuthorDate: Mon Apr 7 13:09:38 2025 +0200
Commit:     Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CommitDate: Fri Apr 11 17:27:59 2025 +0100

    tools/libxl: do not use `-c -E` compiler options together
    
    It makes no sense to request for preprocessor only output and also request
    object file generation.  Fix the _libxl.api-for-check target to only use
    -E (preprocessor output).
    
    Also Clang 20.0 reports an error if both options are used.
    
    Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Fixes: 2862bf5b6c81 ('libxl: enforce prohibitions of internal callers')
    Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
    Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
    Acked-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
    (cherry picked from commit a235f856e4bbd270b085590e1f5fc9599234dcdf)
---
 tools/libs/light/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/libs/light/Makefile b/tools/libs/light/Makefile
index 37e4d16709..b690d92159 100644
--- a/tools/libs/light/Makefile
+++ b/tools/libs/light/Makefile
@@ -195,7 +195,7 @@ libxl.api-ok: check-libxl-api-rules _libxl.api-for-check
        touch $@
 
 _libxl.api-for-check: $(XEN_INCLUDE)/libxl.h
-       $(CC) $(CPPFLAGS) $(CFLAGS) -c -E $< $(APPEND_CFLAGS) \
+       $(CC) $(CPPFLAGS) $(CFLAGS) -E $< $(APPEND_CFLAGS) \
                -DLIBXL_EXTERNAL_CALLERS_ONLY=LIBXL_EXTERNAL_CALLERS_ONLY \
                >$@.new
        mv -f $@.new $@
--
generated by git-patchbot for /home/xen/git/xen.git#staging-4.18



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.