Re: [Xen-devel] TOT doesn't compile

[Jody Belka <lists-xen@xxxxxxxx>]

On Sat, Jun 26, 2004 at 03:42:28PM -0700, Kip Macy wrote:
> sched_bvt.c: In function `bvt_alloc_task':
> sched_bvt.c:99: warning: use of cast expressions as lvalues is
> deprecated
> sched_bvt.c: In function `bvt_init_scheduler':
> sched_bvt.c:413: warning: use of cast expressions as lvalues is
> deprecated
> make[2]: *** [sched_bvt.o] Error 1
> make[2]: Leaving directory `/x/eng/raidant/bk/xen-tot/xen/common'
  ......
> gcc version 3.3.3 20040412 (Red Hat Linux 3.3.3-7)

ah, looks like i never sent a followup in my "problem building xen"
thread (10 jun). sched_atropos.c also used to have the problem,
was fixed by r1.951. making similar changes in sched_bvt (diff i use
included below) should get it building. this only affects more recent
versions of gcc, as when i built a copy under deb-stable the other
day and forgot to patch first it worked ok.


--- /home/knew/1019/xen/common/sched_bvt.c      2004-06-25 15:03:05.000000000 
+0200
+++ sched_bvt.c 2004-06-23 00:52:34.000000000 +0200
@@ -96,7 +96,8 @@
  */
 int bvt_alloc_task(struct domain *p)
 {
-    if ( (BVT_INFO(p) = kmem_cache_alloc(dom_info_cache)) == NULL )
+    p->sched_priv = kmem_cache_alloc(dom_info_cache,GFP_KERNEL);
+    if ( p->sched_priv == NULL )
         return -1;
     
     return 0;
@@ -410,7 +411,8 @@
 
     for ( i = 0; i < NR_CPUS; i++ )
     {
-        CPU_INFO(i) = kmalloc(sizeof(struct bvt_cpu_info));
+        schedule_data[i].sched_priv = kmalloc(sizeof(struct bvt_cpu_info), 
GFP_KERNEL);
+
         if ( CPU_INFO(i) == NULL )
         {
             printk("Failed to allocate BVT scheduler per-CPU memory!\n");


-- 
Jody Belka
knew (at) pimb (dot) org


-------------------------------------------------------
This SF.Net email sponsored by Black Hat Briefings & Training.
Attend Black Hat Briefings & Training, Las Vegas July 24-29 - 
digital self defense, top technical experts, no vendor pitches, 
unmatched networking opportunities. Visit www.blackhat.com
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/xen-devel