Re: [Xen-devel] xen 2.6.8.1 sparse diff

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

> So, I'm begining to look more closely at xen.  Trying to get it all to
> compile, and work with our hardware.
> 
> After overlaying the 2.6.8.1 sparse tree, I looked at the diff of the source.
> In net/core/skbuff.c, I see a function alloc_skb_from_cache.  This function
> uses goto, when it's not needed.

Firstly, that function is a minimal modification of
alloc_skb(). Secondly, that style of exit/error/unusual path using
'goto' is used throughout Linux, for good reasons:
 1. Having a common exit path per function reduces bugs as only need
    to write epilogue code once. Hence the 'out' label.
 2. Older gcc versions need help in outlining rarely-executed basic
    blocks. Hence the 'nodata' label.

 -- Keir


-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/xen-devel