Re: [Xen-devel] xen Makefile being nasty with EXTRAVERSION

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

Yeah, playing with the directory name is gross!

I'm trying out replacing this with:
 XENVERSION   ?= -xen
 EXTRAVERSION := $(EXTRAVERSION)$(XENVERSION)

I've then changed the repository makefile to override XENVERSION with
-xenU or -xen0 as appropriate. If it works as expected I'll check it
in. 

 -- Keir


> There is a snippet in the xen Makefile like this:
> 
>   EXTRAEXTRAVERSION=$(subst $(findstring $(EXTRAVERSION),$(shell basename 
> $(TOPDIR))),,$(EXTRAVERSION))
>   override EXTRAVERSION:=$(subst 
> linux-$(VERSION).$(PATCHLEVEL).$(SUBLEVEL),,$(shell basename 
> $(TOPDIR)))$(EXTRAEXTRAVERSION)
> 
> Now, this probably works fine if the basename of the kernel directory
> is something common. And it is probably perfectly okay to do that in
> the 'make world' Xen builds. But if Xen is treated like 'just another
> kernel patch' or if distributions wish to provide Xen kernels, this is
> a major pain in the ass.
> 
> Since the kernel-build directory is not named linux-anything, and
> EXTRAVERSION comes from above, I get this in include/linux/version.h:
> 
>   #define UTS_RELEASE "2.6.8kernel-source-2.6.8-xen-shiro-1"
> 
> If those two lines are commented out in the Makefile, everything looks
> as it should be for a separate build.
> 
> Could some sort of an alternative solution to EXTRAVERSION be thought
> of, or atleast a toggle to disable this behaviour?
> 
> -- Naked
> 
> 
> 
> -------------------------------------------------------
> This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
> Use IT products in your business? Tell us what you think of them. Give us
> Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
> http://productguide.itmanagersjournal.com/guidepromo.tmpl
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.sourceforge.net/lists/listinfo/xen-devel



-------------------------------------------------------
This SF.net email is sponsored by: IT Product Guide on ITManagersJournal
Use IT products in your business? Tell us what you think of them. Give us
Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more
http://productguide.itmanagersjournal.com/guidepromo.tmpl
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.sourceforge.net/lists/listinfo/xen-devel