[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] xen Makefile being nasty with EXTRAVERSION
> There is a snippet in the xen Makefile like this: > > EXTRAEXTRAVERSION=$(subst $(findstring $(EXTRAVERSION),$(shell basename > $(TOPDIR))),,$(EXTRAVERSION)) > override EXTRAVERSION:=$(subst > linux-$(VERSION).$(PATCHLEVEL).$(SUBLEVEL),,$(shell basename > $(TOPDIR)))$(EXTRAEXTRAVERSION) > > Now, this probably works fine if the basename of the kernel directory > is something common. And it is probably perfectly okay to do that in > the 'make world' Xen builds. But if Xen is treated like 'just another > kernel patch' or if distributions wish to provide Xen kernels, this is > a major pain in the ass. Yeah, I agree, but its very useful. I propose the following replacement: We test to see whether there's a .extraversion file, and if so override EXTRAVERSION with the contents of the file. This should be compatible with distros and still be convenient for us. There's already quite a bit of 'diversity' with the way different architectures deal with handling default configs etc, so I think we'll get away with this. I'll make the change unless anyone shouts soon. Ian ------------------------------------------------------- This SF.net email is sponsored by: IT Product Guide on ITManagersJournal Use IT products in your business? Tell us what you think of them. Give us Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more http://productguide.itmanagersjournal.com/guidepromo.tmpl _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.sourceforge.net/lists/listinfo/xen-devel
|
![]() |
Lists.xenproject.org is hosted with RackSpace, monitoring our |