Re: [Xen-devel] [request for review] cmpxchg8b asm stuff

[Hollis Blanchard <hollisb@xxxxxxxxxx>]

On Tue, 2005-04-19 at 15:50 +0200, Gerd Knorr wrote:

> Below is my very first attempt to write inline assembler, for atomic
> updates of PAE pagetable entries using cmpxchg8b.  It builds, but is
> completely untested otherwise as I don't have a PAE-enabled guest kernel
> yet ...
> 
> Can someone with more experience than me please have a look at it?
> 
> Thanks,
> 
>   Gerd
> 
> --- xen.orig/arch/x86/mm.c    2005-04-19 11:56:20.000000000 +0200
> +++ xen/arch/x86/mm.c 2005-04-19 15:29:01.000000000 +0200
> @@ -834,12 +846,55 @@ static void free_l4_table(struct pfn_inf
>  
>  #endif /* __x86_64__ */
>  
> +static inline int cmpxchg8b_user(u64 *ptr, u64 oval, u64 nval)
> +{
...
> +}

Shouldn't this go into include/asm-x86/system.h? You can add another
case to the __i386__ cmpxchg_user switch.

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel