[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] x86-64-phys-ma.patch


  • To: Arun Sharma <arun.sharma@xxxxxxxxx>
  • From: Christian Limpach <christian.limpach@xxxxxxxxx>
  • Date: Thu, 12 May 2005 22:30:43 +0100
  • Cc: Ian Pratt <Ian.Pratt@xxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 12 May 2005 21:30:18 +0000
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=JEiz9GAYErPX5c6ercxQMcG/Z6KDqxzet8bv2e0bT1aA8GCfYg/D10GZ9s8oTBPA//EvfyMbU7KQZ1eOaqePGThrfoNFhk8RTh+zsAgrRLtQlT2zgIEnzymh1eIfGi0XD/DiclCh2N/sE4kmblwXnVOHW6+ubm3mnHgjxG49/3M=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

On 5/12/05, Arun Sharma <arun.sharma@xxxxxxxxx> wrote:
> phys is machine physical already. So we shouldn't try to convert guest 
> physical to machine physical.

Are you sure that the test a few lines further down shouldn't use (a
to be defined -- see i386) pte_val_ma to compare the currently
installed pte with the to-be-installed one?  You might be comparing
random values otherwise...

    christian

> 
> Signed-off-by: Arun Sharma <arun.sharma@xxxxxxxxx>
> 
> --- a/linux-2.6.11-xen-sparse/arch/xen/x86_64/mm/init.c 2005-05-12 13:23:19 
> -07:00
> +++ b/linux-2.6.11-xen-sparse/arch/xen/x86_64/mm/init.c 2005-05-12 13:23:19 
> -07:00
> @@ -328,7 +328,7 @@
>                 }
>         }
> 
> -       new_pte = pfn_pte(phys >> PAGE_SHIFT, prot);
> +       new_pte = pfn_pte_ma(phys >> PAGE_SHIFT, prot);
>         pte = pte_offset_kernel(pmd, vaddr);
> 
>         if (!pte_none(*pte) &&
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.