Re: [Xen-devel] [PATCH] make domu_debug run-time option + fix int3 handling for MP

[Christian Limpach <christian.limpach@xxxxxxxxx>]

On 5/16/05, Kip Macy <kmacy@xxxxxxxxxx> wrote:
> I'm not entirely thrilled with the interfaces used to get the domu_debug 
> option
> into xen, but adding yet another argument xc_linux_build and/or adding a
> separate handler for domu_debug didn't seem that clean either. The debug 
> support
> doesn't seem like something Ron would use, so I didn't update the Plan 9
> builder.

Looks allright -- except that the debugger.h changes break the
non-domu_debug usages.  Even if you fix that, I'm not sure we want
debugger_trap_entry to be domu_debug only.  Could you please explain
what the intent is and resend as separate patches?
Maybe a debug_trap_entry wrapper which tests the DOMF_debug flag and
either calls the domu_debug function or the other debugger function
would be better?  Please also leave the #if/#elif construct for easy
switching between the different debugger stubs...

     christian

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel