[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Recent header file changes (cset 1.1619.1.2) break ia64 build


  • To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: "Magenheimer, Dan (HP Labs Fort Collins)" <dan.magenheimer@xxxxxx>
  • Date: Wed, 1 Jun 2005 15:46:55 -0700
  • Delivery-date: Wed, 01 Jun 2005 22:47:07 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcVm+89pRneEHe6MRa26145s1qUayQ==
  • Thread-topic: Recent header file changes (cset 1.1619.1.2) break ia64 build

Yesterday's changes to include/exclude header file
broke the ia64 build.  Could these possibly be changed
back?  These kinds of changes are effectively changing
the API between common and arch and they can be
nasty to track down.

I'd like to get these in so Xen/ia64 can catch up with
Keir's (unrelated) serial console changes.

Thanks,
Dan

1) In include/xen/sched.h, removal of xen/slab.h causes a
   problem.  The cset comment mentioned removing these
   includes from the END of the file.  Indeed xen/domain.h
   was duplicately included, but please re-add the include
   for xen/slab.h (though it can be moved up to the beginning
   of the file, before or after the include of xen/domain.h)

23a24
> #include <xen/slab.h>

2) In include/xen/slab.h, removal of xen/mm.h cause a problem.
   Note that config.h was also removed but this didn't break
   the ia64 build, so take it or leave it, but please add back
   the following.

4a5,6
> #include <xen/mm.h>

3) In include/xen/lib.h.  This was newly added and causes problems.
   Please remove.

8c8
< #include <xen/slab.h>

The x86 build can be fixed more precisely by adding "#include
<xen/slab.h>"
to xen/arch/x86/mtrr/main.c.  (Compile-tested only on x86_32 only.)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.