[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] Off-by-one in cpu_gdt_init


  • To: xen-devel@xxxxxxxxxxxxxxxxxxx
  • From: George Washington Dunlap III <dunlapg@xxxxxxxxx>
  • Date: Mon, 6 Jun 2005 11:35:06 -0400 (EDT)
  • Delivery-date: Mon, 06 Jun 2005 15:34:19 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

I forget what triggered this bug (it was a long time ago), but cpu_gdt_init() is trying to allocate an array, one per frame, based on gdt_descr->size. However, the math currently rounds down instead of up! (I'm pretty sure that when I triggered it, (gdt_descr->size>>PAGE_SHIFT) was 0.)

 -George

+-------------------+----------------------------------------
| dunlapg@xxxxxxxxx | http://www-personal.umich.edu/~dunlapg +-------------------+----------------------------------------
|  Who could move a mountain, who could love their enemy?
|  Who could rejoice in pain, and turn the other cheek?
|       - Rich Mullins, "Surely God is With Us"
+------------------------------------------------------------
| Outlaw Junk Email! Support HR 1748 (www.cauce.org)

Attachment: cpu_gdt_init-bug.patch
Description: Text document

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.