Re: [Xen-devel] [patch] predicate NX flag

["Scott Parish" <srparish@xxxxxxxxxx>]

On Tue, Jun 07, 2005 at 01:45:45PM -0700, Nakajima, Jun wrote:

> Scott Parish wrote:
> > the NX flag should only be set when its use is enabled.
> > 
> > sRp
> 
> Rather than changing __PAGE_KERNEL, I think we should change set_p?d (?
> = g, u, m, e) like
> 
> #define set_pmd(pmdptr, pmdval) xen_l2_entry_update(pmdptr, (pmdval)&
> __supported_pte_mask)

Working on a patch.. there are places that xen_l1_entry_update() is
called directly with __PAGE_KERNEL, should those be converted to a
set_pte, or should xen_l1_entry_update be updated instead of the macros,
or should '& __supported_pte_mask' be hardcoded into these places. I'd
prefer to just modify the xen_l?_entry_update()s

btw, __supported_PTE_mask seems an unfortunate name for a mask that gets
used for other pagetable levels.

sRp

-- 
Scott Parish
Signed-off-by: srparish@xxxxxxxxxx

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel