RE: [Xen-devel] [PATCH] Make strace happy with xeno64.

["Li, Xin B" <xin.b.li@xxxxxxxxx>]

I will test it

Keir Fraser wrote:
> On 10 Jun 2005, at 09:06, Keir Fraser wrote:
> 
>>> Hi Keir, do you have time to take a look at this patch?
>>> -Xin 
>>> 
>>> Li, Xin B wrote:
>>>> On x86_64, strace expects CS == 0x33 for 64bit
>>>> applications and CS == 0x23 for 32bit applications, or
>>>> it will complain. This patch makes strace happy with
>>>> xeno64. 
>> 
>> The CS should be 0x23/0x33 -- no need for masking? Or is
>> the fact that the upcall saved mask appears in bits
>> 16-23 of the '4-byte' CS value a problem? We can move
>> the saved mask if so: I think that would be neater.
> 
> I see that xenlinux places its own save mask at CS+4
> anyway (not CS+2 as Xen does). So I've moved the Xen mask
> to CS+4 too. A very simple patch and you probably now
> will not need to patch the strace path. 
> 
>   -- Keir

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel