[Xen-devel] Re: [PATCH] x64-vmxassist-fix.patch

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 10 Jun 2005, at 23:09, Arun Sharma wrote:

> Fix 64 bit build.
>
> Signed-off-by: Nitin Kamble <nitin.a.kamble@xxxxxxxxx>
> Signed-off-by: Arun Sharma <arun.sharma@xxxxxxxxx>
Surely the correct fix is to put a .code32 at the top of the file? The 
vmxassist stuff should run in 32-bit protected mode: long mode doesn't 
necessarily support VM86 mode (not on amd chips I believe).
I think the checked-in fix is benign but not the right run-time fix. :-)

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel