RE: [Xen-devel] [PATCH] Fixing iopl and ioperm

["Li, Xin B" <xin.b.li@xxxxxxxxx>]

On xeno32, test case iopl02 of LTP will fail, pls see below:

[root@vt-x bin]# uname -a
Linux vt-x 2.6.11.12-xen0 #1 Mon Jun 13 16:58:09 PDT 2005 i686 i686 i386
GNU/Linux
[root@vt-x bin]# ./iopl02
iopl02      1  PASS  :  Expected failure for Invalid privilege level,
errno: 22
iopl02      2  FAIL  :  Unexpected results for Non super-user ; returned
0 (expected -1), errno 0 (expected errno  1)

With the ioport patch, this bug get fixed.

-Xin

Nakajima, Jun wrote:
> Keir Fraser wrote:
>> On 11 Jun 2005, at 06:45, Nakajima, Jun wrote:
>> 
>>> With this patch, x86 and x86-64 share ioport.c, fixing
>>> LTP iopl and ioperm testcase failures (on both). We
>>> found an iopl testcase failing even on x86 xenlinux. 
>>> 
>>> Now x86-64 xenlinux should have the same results
>>> regarding the LTP testcases (as far as we tested).
>> 
>> Why does this patch modify the i386 ioport.c so much? I
>> would expect that you ought to be able to use the
>> xen/i386 ioport.c with no modification at all. The
>> different function prototypes for sys_iopl between i386
>> and x86_64 shouldn't matter -- x86_64 ought to work with
>> teh existing xen/i386 function prototype and function
>> implementation.  
>> 
> That part is basically coming from the implementation of
> set_bitmap; x86 and x86-64 uses different implemenations.
> We'll try that in a sperate patch; I think the x86-64 one
> is simpler. 
> 
> Well I heard the current x86 (_not_ 64-bit) xenlinux
> failed one of LTP iopl/ioperm testcases (and it passes on
> the native Linux). So I expect some changes are required
> there. Maybe that patch should go first. I'll
> double-check it. 
> 
> Jun
> ---
> Intel Open Source Technology Center
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel