[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [PATCH] fix broken ACM


  • To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • From: aq <aquynh@xxxxxxxxx>
  • Date: Thu, 23 Jun 2005 17:04:22 +0900
  • Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Thu, 23 Jun 2005 08:03:26 +0000
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=O4XFnB1XLDzdNUkCs5buWyO/tWnn/z/Dd5htOT3wSqqDEkk4Sa9fp/mjBArhRA5kHn8H4ndwps3SBHqlpx1LiIWhkTGFP/ypbP4LJbjf7+lLZkyQcO6mtv4mdX2If1OKkFIVLS21iKOGnoolkx6QDeIe+2+LnWpuwOJzQLRY7t0=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

On 6/23/05, Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> wrote:
> 
> On 22 Jun 2005, at 18:52, aq wrote:
> 
> > are you sure? on my system, without the patch acm_init() would be
> > defined twice.
> >
> > also, some structrures and global variables  are hidden in the #else
> > (of #if (ACM_USE_SECURITY_POLICY == ACM_NULL_POLICY) )
> >
> >
> > how did you compile acm?
> 
> The whole point is not to bother, if the statically chosen security
> policy is null. 

i see, but the problem occurs if we want to compile it. the reason is
because you grouped null ops together, but you accidentally hide some
structures and variables. also we must enclose the declare of
acm_init() in #if (ACM_USE_SECURITY_POLICY = ACM_NULL_POLICY).  please
see my second patch.

regards,
aq

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.