Re: [Xen-devel] Makefile version.

[aq <aquynh@xxxxxxxxx>]

On 6/25/05, Jimi Xenidis <jimix@xxxxxxxxxxxxxx> wrote:
> >>>>> "KF" == Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> writes:
> 
>  KF> On 25 Jun 2005, at 17:36, Jimi Xenidis wrote:
> 
>  >> Example:
>  >> foo.o: CFLAGS += -DFOO_DEBUG
> 
>  KF> Yeah, we allow those. I think they were added before 3.8x, otherwise we
>  KF> wouldn't use them (we started using $(eval), which is a 3.8x feature,
>  KF> and had complaints from 3.79 users).
> 
> Ok cool, that means I can remove my custom %.o:%.c commands and just
> define CFLAGS for the target.
> would also like to add an $(AFLAGS) to the %.o: %.S rule liek the
> following diffs.
> 
> This allows me to further customize some assemble, paritularly to add
> -Wa,-gdwarf2, as the followign diff shows:
> 
> --- /tmp/geta14981      2005-06-25 14:05:11.000000000 -0400
> +++ Rules.mk    2005-06-25 12:21:57.000000000 -0400
> @@ -80,5 +80,5 @@
>         $(CC) $(CFLAGS) -c $< -o $@
> 
>  %.o: %.S $(HDRS) Makefile
> -       $(CC) $(CFLAGS) -D__ASSEMBLY__ -c $< -o $@
> +       $(CC) $(CFLAGS) $(AFLAGS) -D__ASSEMBLY__ -c $< -o $@
> 

you should always use diff from outside of xen root directory (so
patch would be used with -p1 option). otherwise, it is impossible to
know where to apply this patch (there are many Rules.mk file in the
source tree)


regards,
aq

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel