[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xc_ptrace.c fix

On 3 Jul 2005, at 02:07, Kip Macy wrote:

Could you please apply the following trivial patch (yes I know, gmail
screws up whitespace). It fixes a crash in the gdbserver that can be
hit when debugging linux.

But you set pde_virt immediately above the test that you are patching, if pde_phys[cpu] != pde. And if mmap'ing pde_virt fails, you bail with an error. So how can you get pde_virt[cpu] == NULL at that point -- aren;t you just hiding the real bug?

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.