[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] execve() in reboot.c ?

  • To: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: aq <aquynh@xxxxxxxxx>
  • Date: Mon, 25 Jul 2005 17:53:15 +0900
  • Delivery-date: Mon, 25 Jul 2005 08:51:48 +0000
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition; b=gpBJm92vAnHqk6DYWb55xafbmNOvPHBj5QKB9zb3nOkSHKDEZ9b52P0eqlBiYJRswyHBrLMoxWTsjmBaQdUlLErMUCRKlZDAnjTd8ixVcMCYMEr021TkyD/carMNdEcB5+f7AnK4B3AZs7GOmVevH0b3UP9XbTV1lg22m4XnnIY=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>


Domain kernel has arch/xen/kernel/reboot.c, which executes shutdown
and halt on request. But one problem is that we have the path and
command options fixed in the kernel, like this:

    static char *restart_argv[]  = { "/sbin/shutdown", "-r", "now", NULL };
    static char *poweroff_argv[] = { "/sbin/halt",     "-p",        NULL };

That is kind of violating the rule: kernel should never enforce the
policy to the user. We can see the problem if for example domU uses
busybox instead of sysvinit: busybox doesnt support "halt -p", so "xm
shutdown" cannot shutdown the domU.

Should we care enough to fix this problem?


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.