[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Convert balloon driver to xenstore


  • To: Anthony Liguori <aliguori@xxxxxxxxxx>
  • From: aq <aquynh@xxxxxxxxx>
  • Date: Wed, 3 Aug 2005 12:45:50 +0900
  • Cc: Dan Smith <danms@xxxxxxxxxx>, Rusty Russell <rusty@xxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Wed, 03 Aug 2005 03:44:19 +0000
  • Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=EVHXSpbYWZb925AjL8GUBVkDwtLDLdx8+i1D76yye8oJZWndXWXFAbG9JTpcZ6GZ0S3HLd46DFgOowelioK9rAErDIiJl3tMBJx9fCLXYm1HnFvbGZNWIClY4O/wT57jjUAuEFJ4f28yUIdN0CVdtl3ADifsp2o0wT3xBoFGgnI=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

On 8/3/05, Anthony Liguori <aliguori@xxxxxxxxxx> wrote:
> Rusty Russell wrote:
> 
> >On Tue, 2005-08-02 at 06:51 -0700, Dan Smith wrote:
> >
> >
> >Generally, you will want to do a module_init() and initialize your
> >driver.  If it's in domain 0, it needs to be initialized later (the
> >store isn't up yet): the standard way of doing this is a notifier chain.
> >
> >Something like the following:
> >
> >static struct notifier_block store_notify =
> >{
> >       .notifier_call = balloon_setup,
> >};
> >
> >static int balloon_init()
> >{
> >       if (!xen_start_info.store_evtchn)
> >               register_xenstore_notifier(&store_notify);
> >       else
> >               balloon_setup(&store_notify, 0, NULL);
> >       return 0;
> >}
> >
> >
> How does this look?
> 

looks nice to me. why didnt you provice also the patch for balloon ;-)
 
regards,
aq

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.