[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] tiddyup tools/xenstore/talloc.c

On Thu, 2005-08-11 at 22:58 +0100, Keir Fraser wrote:
> On 11 Aug 2005, at 22:15, Jerone Young wrote:
> > Add check so that p is not operated on if context is not also null.
> >
> > Signed-off-by: Jerone Young <jyoung5@xxxxxxxxxx>
> No idea on this one. I think that case is probably impossible so the 
> test could just be simplified, but probably only tridge knows for sure. 
> :-)

Actually the code is fine: it looks for a reference to the given parent
context.  p + 1 cannot be NULL, since either p is NULL, or (p + 1) has
at some stage been returned by _talloc(), which cannot return NULL.

> I think xenstore can probably be weaned off talloc at some point.

Heh, good luck with that!  Removing the destructors and replacing them
with explicit calls would not be too complicated, as the structures are
all fairly simple, but you'll be chasing down memory leaks for a long
time through all the failure paths.

You will have lots and lots of fun handling out-of-memory conditions,
which we do at the moment although, regrettably, not everywhere: if
destroy_path() fails we abort the daemon 8(.

Actually, the OOM code is ugly and I'd love to get rid of it, but I know
people like these kind of checks, even if they're never 100%.

A bad analogy is like a leaky screwdriver -- Richard Braakman

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.